Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1553)

Unified Diff: runtime/observatory/tests/service/pause_on_exceptions_test.dart

Issue 1399743002: Straw man setExceptionPauseMode (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/src/service/object.dart ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/pause_on_exceptions_test.dart
diff --git a/runtime/observatory/tests/service/pause_on_exceptions_test.dart b/runtime/observatory/tests/service/pause_on_exceptions_test.dart
index a9f9ece51301e6f8385f58e62adca39d484a6f33..03d4731f382add97509ed035d1123e1357fb3334 100644
--- a/runtime/observatory/tests/service/pause_on_exceptions_test.dart
+++ b/runtime/observatory/tests/service/pause_on_exceptions_test.dart
@@ -51,13 +51,13 @@ var tests = [
}
});
- test(String pauseInfo,
+ test(String pauseMode,
String expression,
bool shouldPause,
bool shouldBeCaught) async {
- print("Evaluating $expression with pause on $pauseInfo exception");
+ print("Evaluating $expression with pause on $pauseMode exception");
- expect((await isolate.setExceptionPauseInfo(pauseInfo)) is DartError,
+ expect((await isolate.setExceptionPauseMode(pauseMode)) is DartError,
isFalse);
var t;
@@ -94,14 +94,14 @@ var tests = [
}
}
- await test("all", "doCaught()", true, true);
- await test("all", "doUncaught()", true, false);
+ await test("All", "doCaught()", true, true);
+ await test("All", "doUncaught()", true, false);
- await test("unhandled", "doCaught()", false, true);
- await test("unhandled", "doUncaught()", true, false);
+ await test("Unhandled", "doCaught()", false, true);
+ await test("Unhandled", "doUncaught()", true, false);
- await test("none", "doCaught()", false, true);
- await test("none", "doUncaught()", false, false);
+ await test("None", "doCaught()", false, true);
+ await test("None", "doUncaught()", false, false);
subscription.cancel();
},
« no previous file with comments | « runtime/observatory/lib/src/service/object.dart ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698