1. Do not mark an object by storing the object id used during serialization in the object header.

1. Do not mark an object by storing the object id used during serialization in the object header.

2. Removed all the GC task locking code which was needed to ensure that a garbage collection was not in progress when writing a message as the message writer was manipulating the object header

3. Use the rawobject => object_id hash map to store and retrieve the object id for an object.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/f92f63baa5277b84aa7152466a2e3c85db1d2575

[siva, 2015-10-12 23:09:15]

asiva@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2015-10-13 17:58:52]

LGTM

https://chromiumcodereview.appspot.com/1399663002/diff/60001/runtime/vm/snaps...
File runtime/vm/snapshot.cc (right):

https://chromiumcodereview.appspot.com/1399663002/diff/60001/runtime/vm/snaps...
runtime/vm/snapshot.cc:1196:
Instructions::InstanceSize(instructions->ptr()->size_);
instructions->Size()

https://chromiumcodereview.appspot.com/1399663002/diff/60001/runtime/vm/snaps...
runtime/vm/snapshot.cc:2030: if (!vm_isolate_is_symbolic_) {
if (vm_isolate_snapshot_buffer() != NULL) {
 WriteVmIsolateSnapshot();
}
WriteIsolateFullSnapshot();

if (snapshot_code_) {
  instructions_writer_->WriteAssembly();
  instructions_snapshot_size_ = instructions_writer_->BytesWritten();
}

[siva, 2015-10-13 22:07:28]

https://chromiumcodereview.appspot.com/1399663002/diff/60001/runtime/vm/snaps...
File runtime/vm/snapshot.cc (right):

https://chromiumcodereview.appspot.com/1399663002/diff/60001/runtime/vm/snaps...
runtime/vm/snapshot.cc:1196:
Instructions::InstanceSize(instructions->ptr()->size_);
On 2015/10/13 17:58:52, rmacnak wrote:
> instructions->Size()

Done.

https://chromiumcodereview.appspot.com/1399663002/diff/60001/runtime/vm/snaps...
runtime/vm/snapshot.cc:2030: if (!vm_isolate_is_symbolic_) {
On 2015/10/13 17:58:52, rmacnak wrote:
> if (vm_isolate_snapshot_buffer() != NULL) {
>  WriteVmIsolateSnapshot();
> }
> WriteIsolateFullSnapshot();
> 
> if (snapshot_code_) {
>   instructions_writer_->WriteAssembly();
>   instructions_snapshot_size_ = instructions_writer_->BytesWritten();
> }

Done.

[siva, 2015-10-13 22:26:08]

Committed patchset #5 (id:80001) manually as
f92f63baa5277b84aa7152466a2e3c85db1d2575 (presubmit successful).