Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Unified Diff: runtime/vm/dart_api_message.cc

Issue 1399663002: 1. Do not mark an object by storing the object id used during serialization in the object header. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: code-review-comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/raw_object_snapshot.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_message.cc
diff --git a/runtime/vm/dart_api_message.cc b/runtime/vm/dart_api_message.cc
index 623cfc137d99101b39b052012d0bc64ae509c0e4..a4e47bbd97154a8fcdf79e2fa9cbaae747f70254 100644
--- a/runtime/vm/dart_api_message.cc
+++ b/runtime/vm/dart_api_message.cc
@@ -1235,7 +1235,7 @@ bool ApiMessageWriter::WriteCObjectInlined(Dart_CObject* object,
}
WriteIndexedObject(class_id);
- WriteTags(RawObject::ClassIdTag::update(class_id, 0));
+ WriteTags(0);
WriteSmi(len);
switch (class_id) {
case kTypedDataInt8ArrayCid:
@@ -1269,8 +1269,7 @@ bool ApiMessageWriter::WriteCObjectInlined(Dart_CObject* object,
WriteInlinedHeader(object);
// Write out the class and tag information.
WriteIndexedObject(kExternalTypedDataUint8ArrayCid);
- WriteTags(RawObject::ClassIdTag::update(
- kExternalTypedDataUint8ArrayCid, 0));
+ WriteTags(0);
intptr_t length = object->value.as_external_typed_data.length;
if (length < 0 ||
length > ExternalTypedData::MaxElements(
« no previous file with comments | « no previous file | runtime/vm/raw_object_snapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698