Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 1399653002: gpu: Enable virtual contexts with nvidia drivers only (Closed)

Created:
5 years, 2 months ago by hendrikw
Modified:
5 years, 2 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Enable virtual contexts with nvidia drivers only virtual contexts were enabled to combat slow MakeCurrent calls with NVIDIA drivers, and possibly others (others were not tested). Unfortunately, this seems to have caused some problems with the Intel opensource MESA drivers. As a result, I'm disabling it for everything but NVIDIA. I'm trying to get a system set up where we can hopefully repro these issues on linux, maybe we'll be able to fix it, or we can contact the driver devs. BUG=446530 BUG=514510 Committed: https://crrev.com/9090371ec632dfa86daf43cc8b5309938d238e17 Cr-Commit-Position: refs/heads/master@{#353184}

Patch Set 1 #

Patch Set 2 : Update the reason text as well #

Total comments: 1

Patch Set 3 : bump version number (pls don't conflict, k, thanks!) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
hendrikw
PTAL. I haven't tested it on non-NVIDIA drivers yet, kindof assuming it will work. In ...
5 years, 2 months ago (2015-10-08 21:52:52 UTC) #2
piman
LGTM, but please bump the version. https://codereview.chromium.org/1399653002/diff/20001/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/1399653002/diff/20001/gpu/config/gpu_driver_bug_list_json.cc#newcode22 gpu/config/gpu_driver_bug_list_json.cc:22: "version": "8.26", Version ...
5 years, 2 months ago (2015-10-08 22:58:26 UTC) #3
hendrikw
On 2015/10/08 22:58:26, piman (slow to review) wrote: > LGTM, but please bump the version. ...
5 years, 2 months ago (2015-10-08 23:01:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399653002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399653002/40001
5 years, 2 months ago (2015-10-08 23:02:31 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-09 00:27:48 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 00:28:50 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9090371ec632dfa86daf43cc8b5309938d238e17
Cr-Commit-Position: refs/heads/master@{#353184}

Powered by Google App Engine
This is Rietveld 408576698