Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1384)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1399623004: Remove cycle breaking include from mksnapshot.cc file. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
Reviewers:
mvstanton, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_issue-cr-539273-reland
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove cycle breaking include from mksnapshot.cc file. R=mvstanton@chromium.org Committed: https://crrev.com/c84c96caa272d32ca5b03a63c89763c09f86a561 Cr-Commit-Position: refs/heads/master@{#31215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M src/factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/snapshot/mksnapshot.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/type-feedback-vector.h View 1 chunk +1 line, -3 lines 0 comments Download

Depends on Patchset:

Issue 1393773004 Patch 1

Messages

Total messages: 7 (1 generated)
Michael Starzinger
5 years, 2 months ago (2015-10-12 12:23:12 UTC) #1
Yang
On 2015/10/12 12:23:12, Michael Starzinger wrote: lgtm.
5 years, 2 months ago (2015-10-12 13:23:00 UTC) #2
mvstanton
lgtm
5 years, 2 months ago (2015-10-12 14:05:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399623004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399623004/1
5 years, 2 months ago (2015-10-12 15:18:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-12 15:21:24 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 15:21:32 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c84c96caa272d32ca5b03a63c89763c09f86a561
Cr-Commit-Position: refs/heads/master@{#31215}

Powered by Google App Engine
This is Rietveld 408576698