Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1393773004: Reland "[heap] No leakage of mark-compact.h outside of heap." (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[heap] No leakage of mark-compact.h outside of heap." The revert of the original change in question did not recover regressions, which allows us to reland this cleanup after all. This reverts commit 871529b4d86c406b4139129f138d88177a728a09. R=hpayer@chromium.org Committed: https://crrev.com/e494bcca7e9391a0d593046dfd7b341f659fafd1 Cr-Commit-Position: refs/heads/master@{#31214}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -22 lines) Patch
M src/heap/heap.h View 3 chunks +3 lines, -4 lines 0 comments Download
M src/heap/heap.cc View 10 chunks +21 lines, -14 lines 0 comments Download
M src/heap/incremental-marking.h View 3 chunks +6 lines, -3 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 2 months ago (2015-10-12 12:00:47 UTC) #1
Hannes Payer (out of office)
lgtm
5 years, 2 months ago (2015-10-12 14:49:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393773004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393773004/1
5 years, 2 months ago (2015-10-12 14:58:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-12 15:20:18 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 15:20:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e494bcca7e9391a0d593046dfd7b341f659fafd1
Cr-Commit-Position: refs/heads/master@{#31214}

Powered by Google App Engine
This is Rietveld 408576698