Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 13996009: Revert 194560 "[SPDY] Replace SpdyIOBuffer with new SpdyBuffer c..." (Closed)

Created:
7 years, 8 months ago by akalin
Modified:
7 years, 8 months ago
Reviewers:
akalin
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 194560 "[SPDY] Replace SpdyIOBuffer with new SpdyBuffer c..." > [SPDY] Replace SpdyIOBuffer with new SpdyBuffer class > > Use SpdyBuffer for both SPDY reads and writes. A future > CL will add hooks to SpdyBuffer so that we keep track of > flow control windows properly. > > Replace SpdyFrameProducer with SpdyBufferProducer. > > Also introduce new SpdyReadQueue class for delegates > of SpdyStream to use. > > BUG=176592 > > Review URL: https://codereview.chromium.org/13990005 TBR=akalin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194562

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -769 lines) Patch
M trunk/src/net/net.gyp View 4 chunks +4 lines, -8 lines 0 comments Download
D trunk/src/net/spdy/spdy_buffer.h View 1 chunk +0 lines, -66 lines 0 comments Download
D trunk/src/net/spdy/spdy_buffer.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D trunk/src/net/spdy/spdy_buffer_producer.h View 1 chunk +0 lines, -50 lines 0 comments Download
D trunk/src/net/spdy/spdy_buffer_producer.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D trunk/src/net/spdy/spdy_buffer_unittest.cc View 1 chunk +0 lines, -88 lines 0 comments Download
A + trunk/src/net/spdy/spdy_frame_producer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/net/spdy/spdy_frame_producer.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
MM trunk/src/net/spdy/spdy_http_stream.h View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/net/spdy/spdy_http_stream.cc View 4 chunks +35 lines, -10 lines 0 comments Download
A + trunk/src/net/spdy/spdy_io_buffer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/net/spdy/spdy_io_buffer.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
MM trunk/src/net/spdy/spdy_proxy_client_socket.h View 5 chunks +5 lines, -7 lines 0 comments Download
MM trunk/src/net/spdy/spdy_proxy_client_socket.cc View 7 chunks +40 lines, -26 lines 0 comments Download
D trunk/src/net/spdy/spdy_read_queue.h View 1 chunk +0 lines, -51 lines 0 comments Download
D trunk/src/net/spdy/spdy_read_queue.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D trunk/src/net/spdy/spdy_read_queue_unittest.cc View 1 chunk +0 lines, -106 lines 0 comments Download
M trunk/src/net/spdy/spdy_session.h View 5 chunks +12 lines, -20 lines 0 comments Download
M trunk/src/net/spdy/spdy_session.cc View 13 chunks +52 lines, -66 lines 0 comments Download
M trunk/src/net/spdy/spdy_session_spdy2_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/net/spdy/spdy_session_spdy3_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/net/spdy/spdy_stream.h View 5 chunks +7 lines, -9 lines 0 comments Download
M trunk/src/net/spdy/spdy_stream.cc View 13 chunks +35 lines, -38 lines 0 comments Download
M trunk/src/net/spdy/spdy_stream_test_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/net/spdy/spdy_stream_test_util.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M trunk/src/net/spdy/spdy_websocket_stream.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/net/spdy/spdy_websocket_stream.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/net/spdy/spdy_websocket_stream_spdy2_unittest.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M trunk/src/net/spdy/spdy_websocket_stream_spdy3_unittest.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M trunk/src/net/spdy/spdy_write_queue.h View 4 chunks +6 lines, -7 lines 0 comments Download
M trunk/src/net/spdy/spdy_write_queue.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/net/spdy/spdy_write_queue_unittest.cc View 9 chunks +24 lines, -26 lines 0 comments Download
M trunk/src/net/websockets/websocket_job.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/websockets/websocket_job.cc View 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
akalin
7 years, 8 months ago (2013-04-17 10:16:17 UTC) #1
akalin
7 years, 8 months ago (2013-04-17 10:16:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r194562.

Powered by Google App Engine
This is Rietveld 408576698