Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: trunk/src/net/spdy/spdy_http_stream.h

Issue 13996009: Revert 194560 "[SPDY] Replace SpdyIOBuffer with new SpdyBuffer c..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/net/spdy/spdy_frame_producer.cc ('k') | trunk/src/net/spdy/spdy_http_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/net/spdy/spdy_http_stream.h
===================================================================
--- trunk/src/net/spdy/spdy_http_stream.h (revision 194561)
+++ trunk/src/net/spdy/spdy_http_stream.h (working copy)
@@ -13,7 +13,6 @@
#include "net/base/completion_callback.h"
#include "net/base/net_log.h"
#include "net/http/http_stream.h"
-#include "net/spdy/spdy_read_queue.h"
#include "net/spdy/spdy_stream.h"
namespace net {
@@ -90,7 +89,7 @@
base::Time response_time,
int status) OVERRIDE;
virtual void OnHeadersSent() OVERRIDE;
- virtual int OnDataReceived(scoped_ptr<SpdyBuffer> buffer) OVERRIDE;
+ virtual int OnDataReceived(const char* buffer, int bytes) OVERRIDE;
virtual void OnDataSent(size_t bytes_sent) OVERRIDE;
virtual void OnClose(int status) OVERRIDE;
@@ -140,7 +139,8 @@
bool response_headers_received_; // Indicates waiting for more HEADERS.
// We buffer the response body as it arrives asynchronously from the stream.
- SpdyReadQueue response_body_queue_;
+ // TODO(mbelshe): is this infinite buffering?
+ std::list<scoped_refptr<IOBufferWithSize> > response_body_;
CompletionCallback callback_;
Property changes on: trunk/src/net/spdy/spdy_http_stream.h
___________________________________________________________________
Deleted: svn:mergeinfo
« no previous file with comments | « trunk/src/net/spdy/spdy_frame_producer.cc ('k') | trunk/src/net/spdy/spdy_http_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698