Issue 1399523003: Subzero: Don't bother printing stack/frame ptr as part of LiveIn/LiveOut.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1399523003: Subzero: Don't bother printing stack/frame ptr as part of LiveIn/LiveOut. (Closed)

Created:
5 years, 2 months ago by Jim Stichnoth

Modified:
5 years, 2 months ago

Reviewers:
sehr (please use chromium), Karl, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Subzero: Don't bother printing stack/frame ptr as part of LiveIn/LiveOut. The LiveIn and LiveOut register sets are printed for each basic block in -asm-verbose mode. These sets would generally include the stack and/or frame pointer registers, which is just noise, so we suppress that. BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=e74187190924104542649aecbef4795642b8140c

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -8 lines)			Patch
M	src/IceCfgNode.cpp	View	2 chunks	+13 lines, -8 lines	0 comments	Download
M	src/IceTargetLowering.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/IceTargetLoweringARM32.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/IceTargetLoweringMIPS32.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/IceTargetLoweringX86Base.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Jim Stichnoth

5 years, 2 months ago (2015-10-09 13:54:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e74187190924104542649aecbef4795642b8140c (presubmit successful).