Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1204)

Issue 13995003: MIPS: Stack traversal doesn't work properly on Arm simulator so disabling the test there. (Closed)

Created:
7 years, 8 months ago by palfia
Modified:
7 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Stack traversal doesn't work properly on Arm simulator so disabling the test there. Port r14213 (b1281528) BUG=

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M test/cctest/cctest.status View 1 chunk +6 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
palfia
7 years, 8 months ago (2013-04-11 00:18:37 UTC) #1
Paul Lind
lgtm
7 years, 8 months ago (2013-04-11 00:38:09 UTC) #2
Paul Lind
@danno - could you kindly provide an LGTM for us, mine has no powers here.
7 years, 8 months ago (2013-04-11 02:44:10 UTC) #3
yurys
The issue title is misleading. Originally the bug was about Arm _simulator_ only. Do you ...
7 years, 8 months ago (2013-04-11 04:16:57 UTC) #4
yurys
Looks like I've got a fix for simulators so this change should not be needed: ...
7 years, 8 months ago (2013-04-11 09:22:02 UTC) #5
palfia
7 years, 7 months ago (2013-05-09 22:54:47 UTC) #6
Thanks, fixed by r14235, works on both simulator and hw. Closing issue.

Powered by Google App Engine
This is Rietveld 408576698