third_party/WebKit/Source/core/layout/LayoutBlock.h - Issue 1399493002: Column balancing refactoring. Don't propagate data during layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.h

Issue 1399493002: Column balancing refactoring. Don't propagate data during layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more code review Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ColumnBalancer.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBlock.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.h b/third_party/WebKit/Source/core/layout/LayoutBlock.h

index 258716b91bb44c5c61544797cc0fb4fd125c863d..6e941b0e0f234c8f60d00fe173f605fd5c83b7bb 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlock.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.h

@@ -446,8 +446,10 @@ protected:

bool createsNewFormattingContext() const;

- // A page break is required at some offset due to space shortage in the current fragmentainer.

- void setPageBreak(LayoutUnit offset, LayoutUnit spaceShortage);

+ // Paginated content inside this block was laid out.

+ // |logicalTopOffsetAfterPagination| is the logical top offset of the child content after

+ // applying any forced or unforced break, if needed.

+ void paginatedContentWasLaidOut(LayoutUnit logicalTopOffsetAfterPagination);

// Update minimum page height required to avoid fragmentation where it shouldn't occur (inside

// unbreakable content, between orphans and widows, etc.). This will be used as a hint to the

« no previous file with comments | « third_party/WebKit/Source/core/layout/ColumnBalancer.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »