Issue 139943005: Convert extensions::ProcessMap to BrowserContextKeyedService

Issue 139943005: Convert extensions::ProcessMap to BrowserContextKeyedService (Closed)

Created:
6 years, 11 months ago by James Cook

Modified:
6 years, 11 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, extensions-reviews_chromium.org, jar (doing other things), yoshiki+watch_chromium.org, asvitkine+watch_chromium.org, Michael van Ouwerkerk, chromium-apps-reviews_chromium.org, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Convert extensions::ProcessMap to BrowserContextKeyedService This allows us to remove more ExtensionService dependencies, which we need to do because app_shell doesn't have an ExtensionService. BUG=334706 TEST=existing unit_tests, browser_tests TBR=sky@chromium.org for mechanical changes across the non-extensions bits of chrome/browser/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245556

Patch Set 1 #

Patch Set 2 : rebase process_map #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+182 lines, -76 lines)			Patch
M	chrome/browser/chrome_content_browser_client.cc	View	1	7 chunks	+20 lines, -18 lines	0 comments	Download
M	chrome/browser/extensions/app_process_apitest.cc	View		10 chunks	+20 lines, -19 lines	0 comments	Download
M	chrome/browser/extensions/extension_crash_recovery_browsertest.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_function_dispatcher.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_service.h	View		4 chunks	+2 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/extension_service.cc	View	1	3 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/isolated_app_browsertest.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/process_management_browsertest.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/geolocation/chrome_geolocation_permission_context.cc	View		2 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/memory_details.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/metrics/metrics_service.cc	View		3 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/task_manager/tab_contents_resource_provider.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/browser/event_router.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	extensions/browser/process_map.h	View		3 chunks	+12 lines, -3 lines	0 comments	Download
M	extensions/browser/process_map.cc	View		3 chunks	+8 lines, -1 line	0 comments	Download
A	extensions/browser/process_map_factory.h	View		1 chunk	+42 lines, -0 lines	0 comments	Download
A	extensions/browser/process_map_factory.cc	View		1 chunk	+46 lines, -0 lines	0 comments	Download
M	extensions/extensions.gyp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/139943005/80001

6 years, 11 months ago (2014-01-17 16:34:01 UTC) #3

Message was sent while issue was closed.

Change committed as 245556

Expand Messages | Collapse Messages