chrome/browser/metrics/metrics_service.cc - Issue 139943005: Convert extensions::ProcessMap to BrowserContextKeyedService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_service.cc

Issue 139943005: Convert extensions::ProcessMap to BrowserContextKeyedService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase process_map Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/metrics_service.cc

diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc

index b96af841a3031eb720b8eba5527e73456fd05c00..c05dbbc19bc63b90e905634b219bd3f12709fe45 100644

--- a/chrome/browser/metrics/metrics_service.cc

+++ b/chrome/browser/metrics/metrics_service.cc

@@ -186,7 +186,6 @@

#include "base/values.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/chrome_notification_types.h"

-#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/io_thread.h"

#include "chrome/browser/memory_details.h"

#include "chrome/browser/metrics/compression_utils.h"

@@ -199,7 +198,6 @@

#include "chrome/browser/net/http_pipelining_compatibility_client.h"

#include "chrome/browser/net/network_stats.h"

#include "chrome/browser/omnibox/omnibox_log.h"

-#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser_list.h"

#include "chrome/browser/ui/browser_otr_state.h"

#include "chrome/browser/ui/search/search_tab_helper.h"

@@ -1760,10 +1758,9 @@ void MetricsService::LogLoadStarted(content::WebContents* web_contents) {

void MetricsService::LogRendererCrash(content::RenderProcessHost* host,

base::TerminationStatus status,

int exit_code) {

- Profile* profile = Profile::FromBrowserContext(host->GetBrowserContext());

- ExtensionService* service = profile->GetExtensionService();

bool was_extension_process =

- service && service->process_map()->Contains(host->GetID());

+ extensions::ProcessMap::Get(host->GetBrowserContext())

+ ->Contains(host->GetID());

if (status == base::TERMINATION_STATUS_PROCESS_CRASHED ||

status == base::TERMINATION_STATUS_ABNORMAL_TERMINATION) {

if (was_extension_process) {