Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 139923006: [Cleanup] Follow Up of Pinch/Zoom Infrastucture & Plumbing CL (Closed)

Created:
6 years, 10 months ago by deepak.sa
Modified:
6 years, 10 months ago
CC:
blink-reviews, blink-layers+watch_chromium.org, kenneth.christiansen, dglazkov+blink, jamesr, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[Cleanup] Follow Up of Pinch/Zoom Infrastucture & Plumbing CL Follow up of Pinch/Zoom Infrastructure & Plumbing CL to remove methods related to max scroll offset and making clip layer methods pure virtual. This CL is followup on https://codereview.chromium.org/23983047. BUG=148816 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166454

Patch Set 1 #

Total comments: 4

Patch Set 2 : nit work. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/web/PinchViewports.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M public/platform/WebLayer.h View 1 2 chunks +1 line, -7 lines 0 comments Download
M public/platform/WebScrollbarLayer.h View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
deepak.sa
Please have a look.
6 years, 10 months ago (2014-01-31 13:01:32 UTC) #1
wjmaclean
lgtm, thanks! https://codereview.chromium.org/139923006/diff/1/public/platform/WebLayer.h File public/platform/WebLayer.h (right): https://codereview.chromium.org/139923006/diff/1/public/platform/WebLayer.h#newcode176 public/platform/WebLayer.h:176: virtual void setScrollClipLayer(WebLayer*) = 0; nit: Don't ...
6 years, 10 months ago (2014-01-31 13:38:24 UTC) #2
deepak.sa
https://codereview.chromium.org/139923006/diff/1/public/platform/WebLayer.h File public/platform/WebLayer.h (right): https://codereview.chromium.org/139923006/diff/1/public/platform/WebLayer.h#newcode176 public/platform/WebLayer.h:176: virtual void setScrollClipLayer(WebLayer*) = 0; On 2014/01/31 13:38:25, wjmaclean ...
6 years, 10 months ago (2014-02-01 09:15:24 UTC) #3
deepak.sa
The CQ bit was checked by deepak.sa@samsung.com
6 years, 10 months ago (2014-02-01 09:22:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/139923006/80001
6 years, 10 months ago (2014-02-01 09:22:58 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-01 10:08:14 UTC) #6
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=15130
6 years, 10 months ago (2014-02-01 10:08:15 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 10:08:15 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 10:08:19 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 10:08:23 UTC) #10
deepak.sa
On 2014/01/31 13:38:24, wjmaclean wrote: > lgtm, thanks! > > https://codereview.chromium.org/139923006/diff/1/public/platform/WebLayer.h > File public/platform/WebLayer.h (right): ...
6 years, 10 months ago (2014-02-03 07:35:18 UTC) #11
abarth-chromium
lgtm
6 years, 10 months ago (2014-02-03 20:53:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/139923006/80001
6 years, 10 months ago (2014-02-03 20:53:27 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 02:18:22 UTC) #14
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=10631
6 years, 10 months ago (2014-02-04 02:18:23 UTC) #15
deepak.sa
The CQ bit was checked by deepak.sa@samsung.com
6 years, 10 months ago (2014-02-05 05:40:22 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/139923006/80001
6 years, 10 months ago (2014-02-05 05:40:37 UTC) #17
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 05:40:54 UTC) #18
Message was sent while issue was closed. 
Change committed as 166454

Powered by Google App Engine
This is Rietveld 408576698