Source/web/PinchViewports.cpp - Issue 139923006: [Cleanup] Follow Up of Pinch/Zoom Infrastucture & Plumbing CL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/PinchViewports.cpp

Issue 139923006: [Cleanup] Follow Up of Pinch/Zoom Infrastucture & Plumbing CL (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: nit work. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/PinchViewports.cpp

diff --git a/Source/web/PinchViewports.cpp b/Source/web/PinchViewports.cpp

index d9b63ffa7b540d1bdc359748ed889c4161a302c9..82f97a6b9b3e9293d380e2482a2e5ce2f181b494 100644

--- a/Source/web/PinchViewports.cpp

+++ b/Source/web/PinchViewports.cpp

@@ -73,8 +73,6 @@ PinchViewports::PinchViewports(WebViewImpl* owner)

// dynamically-sized viewports on Android.

m_innerViewportContainerLayer->setMasksToBounds(false);

- // TODO(wjmaclean) Remove next line once https://codereview.chromium.org/23983047 lands.

- m_innerViewportScrollLayer->platformLayer()->setScrollable(true);

m_innerViewportScrollLayer->platformLayer()->setScrollClipLayer(

m_innerViewportContainerLayer->platformLayer());

m_innerViewportScrollLayer->platformLayer()->setUserScrollable(true, true);

« no previous file with comments | « Source/core/page/scrolling/ScrollingCoordinator.cpp ('k') | public/platform/WebLayer.h » ('j') | no next file with comments »