Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1163)

Unified Diff: chrome/browser/local_discovery/service_discovery_device_lister.cc

Issue 139923002: Added VLOG(1) loggings to mdns extensions API code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/local_discovery/service_discovery_device_lister.cc
diff --git a/chrome/browser/local_discovery/service_discovery_device_lister.cc b/chrome/browser/local_discovery/service_discovery_device_lister.cc
index 0d906459a1502de01fa43126fdbad320dd4846b0..ebf18c97433b5748f1881a2dccd697a330c607a4 100644
--- a/chrome/browser/local_discovery/service_discovery_device_lister.cc
+++ b/chrome/browser/local_discovery/service_discovery_device_lister.cc
@@ -32,16 +32,21 @@ ServiceDiscoveryDeviceLister::~ServiceDiscoveryDeviceLister() {
}
void ServiceDiscoveryDeviceLister::Start() {
+ VLOG(1) << "Start: service_type: " << service_type_;
Vitaly Buka (NO REVIEWS) 2014/01/15 23:08:51 Maybe DeviceListerStart
imcheng 2014/01/15 23:30:18 Done.
CreateServiceWatcher();
}
void ServiceDiscoveryDeviceLister::DiscoverNewDevices(bool force_update) {
+ VLOG(1) << "DiscoverNewDevices, service_type: " << service_type_;
Vitaly Buka (NO REVIEWS) 2014/01/15 23:08:51 Inconsistent separator, should be DiscoverNewDevic
imcheng 2014/01/15 23:30:18 Done.
service_watcher_->DiscoverNewServices(force_update);
}
void ServiceDiscoveryDeviceLister::OnServiceUpdated(
ServiceWatcher::UpdateType update,
const std::string& service_name) {
+ VLOG(1) << "OnServiceUpdated: service_type: " << service_type_
+ << ", service_name: " << service_name
+ << ", UpdateType: " << update;
Vitaly Buka (NO REVIEWS) 2014/01/15 23:08:51 missaligned UpdateType-> update
imcheng 2014/01/15 23:30:18 Done.
if (update == ServiceWatcher::UPDATE_INVALIDATED) {
resolvers_.clear();
CreateServiceWatcher();
@@ -58,6 +63,7 @@ void ServiceDiscoveryDeviceLister::OnServiceUpdated(
// If there is already a resolver working on this service, don't add one.
if (insert_result.second) {
+ VLOG(1) << "Adding resolver for service_name: " << service_name;
scoped_ptr<ServiceResolver> resolver =
service_discovery_client_->CreateServiceResolver(
service_name, base::Bind(
@@ -68,6 +74,9 @@ void ServiceDiscoveryDeviceLister::OnServiceUpdated(
insert_result.first->second.reset(resolver.release());
insert_result.first->second->StartResolving();
+ } else {
+ VLOG(1) << "Resolver for service_name already exists, ignoring: "
Vitaly Buka (NO REVIEWS) 2014/01/15 23:08:51 Resolver already exists, service_name:
imcheng 2014/01/15 23:30:18 Done.
+ << service_name;
}
} else {
delegate_->OnDeviceRemoved(service_name);
@@ -80,6 +89,9 @@ void ServiceDiscoveryDeviceLister::OnResolveComplete(
std::string service_name,
ServiceResolver::RequestStatus status,
const ServiceDescription& service_description) {
+ VLOG(1) << "OnResolveComplete: service_type: " << service_type_
+ << ", service_name: " << service_name
Vitaly Buka (NO REVIEWS) 2014/01/15 23:08:51 missaligned
imcheng 2014/01/15 23:30:18 Done.
+ << ", status: " << status;
if (status == ServiceResolver::STATUS_SUCCESS) {
delegate_->OnDeviceChanged(added, service_description);

Powered by Google App Engine
This is Rietveld 408576698