Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Unified Diff: chrome/browser/extensions/api/mdns/mdns_api.cc

Issue 139923002: Added VLOG(1) loggings to mdns extensions API code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/mdns/mdns_api.cc
diff --git a/chrome/browser/extensions/api/mdns/mdns_api.cc b/chrome/browser/extensions/api/mdns/mdns_api.cc
index 3e30670324c763e66641baa42387f333a1003f8a..4353561e883c25d6eb049d799cd707d6af271878 100644
--- a/chrome/browser/extensions/api/mdns/mdns_api.cc
+++ b/chrome/browser/extensions/api/mdns/mdns_api.cc
@@ -89,9 +89,6 @@ void MDnsAPI::UpdateMDnsListeners(const EventListenerInfo& details) {
for (EventListenerMap::ListenerList::const_iterator it = listeners.begin();
it != listeners.end(); ++it) {
base::DictionaryValue* filter = ((*it)->filter.get());
- for (base::DictionaryValue::Iterator iter(*filter);
- !iter.IsAtEnd(); iter.Advance()) {
- }
std::string filter_value;
filter->GetStringASCII(kEventFilterServiceTypeKey, &filter_value);
@@ -146,6 +143,8 @@ void MDnsAPI::OnDnsSdEvent(const std::string& service_type,
event->restrict_to_browser_context = profile_;
event->filter_info.SetServiceType(service_type);
+ VLOG(1) << "Broadcasting OnServiceList event: " << event.get();
+
// TODO(justinlin): To avoid having listeners without filters getting all
// events, modify API to have this event require filters.
extensions::ExtensionSystem::Get(profile_)->event_router()->

Powered by Google App Engine
This is Rietveld 408576698