Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 13992005: Fix rpath for components when cross-compiling. (Closed)

Created:
7 years, 8 months ago by Yaron
Modified:
7 years, 8 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Visibility:
Public.

Description

Fix rpath for components when cross-compiling. This came up while bringing up the components build for Android. Trying to run v8_shell failed: out/Debug/v8_shell: error while loading shared libraries: libv8.cr.so: cannot open shared object file: No such file or directory readelf -d out/Debug/v8_shell shows the problem: 0x0000000f (RPATH) Library rpath: [$ORIGIN/lib/] For cross-compiles, host shared libraries are placed in /lib/host BUG=chromium:158821 Committed: https://code.google.com/p/gyp/source/detail?r=1607

Patch Set 1 #

Patch Set 2 : add test #

Patch Set 3 : linux-only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -14 lines) Patch
M pylib/gyp/generator/ninja.py View 1 chunk +5 lines, -2 lines 0 comments Download
M test/toolsets/gyptest-toolsets.py View 1 2 1 chunk +16 lines, -8 lines 0 comments Download
M test/toolsets/main.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/toolsets/toolsets.gyp View 1 3 chunks +15 lines, -2 lines 0 comments Download
A + test/toolsets/toolsets_shared.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Yaron
7 years, 8 months ago (2013-04-10 22:31:57 UTC) #1
Nico
Is it possible to write a test for this? I think we have toolset tests ...
7 years, 8 months ago (2013-04-10 23:33:41 UTC) #2
Yaron
Added a test but it fails on mac/win. I think mac needs a similar fix ...
7 years, 8 months ago (2013-04-11 05:50:31 UTC) #3
Nico
Thanks for adding a test! As far as I know, GYP_CROSSCOMPILE and the target / ...
7 years, 8 months ago (2013-04-11 06:26:51 UTC) #4
Yaron
Ok, restricted to linux-only
7 years, 8 months ago (2013-04-11 16:51:53 UTC) #5
Nico
lgtm Thanks!
7 years, 8 months ago (2013-04-11 17:55:57 UTC) #6
Yaron
I get this when trying to dcommit: ERROR from SVN: RA layer request failed: Server ...
7 years, 8 months ago (2013-04-11 18:11:21 UTC) #7
Yaron
7 years, 8 months ago (2013-04-11 18:28:57 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r1607 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698