Source/WebCore/rendering/RenderGrid.cpp - Issue 13992003: Add support for parsing <grid-line> that includes a 'span'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/rendering/RenderGrid.cpp

Issue 13992003: Add support for parsing <grid-line> that includes a 'span' (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/WebCore/rendering/RenderGrid.cpp

diff --git a/Source/WebCore/rendering/RenderGrid.cpp b/Source/WebCore/rendering/RenderGrid.cpp

index a324d3419adac2afa15a6475cca1f509dd7fa069..18bf4fb1f5881f65bba0a2dd3fbef068f4d28956 100644

--- a/Source/WebCore/rendering/RenderGrid.cpp

+++ b/Source/WebCore/rendering/RenderGrid.cpp

@@ -773,6 +773,10 @@ size_t RenderGrid::resolveGridPositionFromStyle(const GridPosition& position, Gr

// 'auto' depends on the opposite position for resolution (e.g. grid-row: auto / 1).

ASSERT_NOT_REACHED();

return 0;

+ case SpanPosition:

+ // FIXME: Handle span positions (crbug.com/229713).

+ ASSERT_NOT_REACHED();

+ return 0;

}

ASSERT_NOT_REACHED();

return 0;