Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 1398883004: [NaCl SDK] Fix create_nmf to include arm/glibc ELF loader (Closed)

Created:
5 years, 2 months ago by Sam Clegg
Modified:
5 years, 2 months ago
CC:
binji+watch_chromium.org, chromium-reviews, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Fix create_nmf to include arm/glibc ELF loader Add tests for ARM glibc nmfs. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk BUG=505885 Committed: https://crrev.com/5afc24479ba6b45f12caaa1fb805930004db2596 Cr-Commit-Position: refs/heads/master@{#354536}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -65 lines) Patch
M native_client_sdk/src/test_all.py View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/tools/create_nmf.py View 1 2 6 chunks +12 lines, -7 lines 0 comments Download
M native_client_sdk/src/tools/lib/get_shared_deps.py View 2 chunks +7 lines, -3 lines 0 comments Download
A + native_client_sdk/src/tools/lib/tests/data/test_dynamic_arm.nexe View 1 Binary file 0 comments Download
M native_client_sdk/src/tools/tests/create_nmf_test.py View 1 2 23 chunks +164 lines, -54 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (7 generated)
Sam Clegg
5 years, 2 months ago (2015-10-15 02:15:02 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398883004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398883004/40001
5 years, 2 months ago (2015-10-15 02:15:22 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_nacl_sdk on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_nacl_sdk/builds/666)
5 years, 2 months ago (2015-10-15 04:29:45 UTC) #7
bradn
Oh, that makes more sense :-), I wasn't sure how the loader worked for arm. ...
5 years, 2 months ago (2015-10-15 04:48:08 UTC) #9
binji
lgtm https://codereview.chromium.org/1398883004/diff/40001/native_client_sdk/src/tools/tests/create_nmf_test.py File native_client_sdk/src/tools/tests/create_nmf_test.py (right): https://codereview.chromium.org/1398883004/diff/40001/native_client_sdk/src/tools/tests/create_nmf_test.py#newcode307 native_client_sdk/src/tools/tests/create_nmf_test.py:307: self.assertEqual(strip_manifest['program'], expected['program']) why separate this out?
5 years, 2 months ago (2015-10-15 17:06:07 UTC) #10
Sam Clegg
https://codereview.chromium.org/1398883004/diff/40001/native_client_sdk/src/tools/tests/create_nmf_test.py File native_client_sdk/src/tools/tests/create_nmf_test.py (right): https://codereview.chromium.org/1398883004/diff/40001/native_client_sdk/src/tools/tests/create_nmf_test.py#newcode307 native_client_sdk/src/tools/tests/create_nmf_test.py:307: self.assertEqual(strip_manifest['program'], expected['program']) On 2015/10/15 17:06:07, binji wrote: > why ...
5 years, 2 months ago (2015-10-15 17:27:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398883004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398883004/60001
5 years, 2 months ago (2015-10-16 17:07:08 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-16 17:37:36 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 17:38:23 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5afc24479ba6b45f12caaa1fb805930004db2596
Cr-Commit-Position: refs/heads/master@{#354536}

Powered by Google App Engine
This is Rietveld 408576698