Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 1403303002: [NaCl SDK] Ship arm_elf_loader.nexe on all platforms (Closed)

Created:
5 years, 2 months ago by Sam Clegg
Modified:
5 years, 2 months ago
Reviewers:
binji
CC:
binji+watch_chromium.org, chromium-reviews, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Ship arm_elf_loader.nexe on all platforms Enable sel_ldr testing glibc/arm builds. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk BUG=505885 Committed: https://crrev.com/5aa1f76df0bdf6350d1987c43b669140e317dd37 Cr-Commit-Position: refs/heads/master@{#354424}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 2 chunks +8 lines, -6 lines 0 comments Download
M native_client_sdk/src/build_tools/sdk_files.list View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/build_tools/test_sdk.py View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Sam Clegg
5 years, 2 months ago (2015-10-15 20:58:06 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403303002/1
5 years, 2 months ago (2015-10-15 20:58:54 UTC) #4
binji
lgtm
5 years, 2 months ago (2015-10-15 21:21:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403303002/20001
5 years, 2 months ago (2015-10-15 22:36:18 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_nacl_sdk on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
5 years, 2 months ago (2015-10-15 23:25:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403303002/20001
5 years, 2 months ago (2015-10-16 00:07:04 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-16 01:42:58 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 01:43:49 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5aa1f76df0bdf6350d1987c43b669140e317dd37
Cr-Commit-Position: refs/heads/master@{#354424}

Powered by Google App Engine
This is Rietveld 408576698