Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1398733002: Move builtin JavaScript sources into own directory. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
Reviewers:
danno, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move builtin JavaScript sources into own directory. This moves JavaScript source files that are bundled with V8 into a separate directory. The goal is to improve code readability and also being able to formalize ideal reviewers by subsequently adding the OWNERS file. These files almost exclusively contain implementations of methods fully specified by ES6. Note that files in the "debug" directory as well as the "d8.js" file aren't affected by this change. R=rossberg@chromium.org Committed: https://crrev.com/e5320d8a5990ab340b63328d3051598fe37dc338 Cr-Commit-Position: refs/heads/master@{#31230}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Also move macros.py file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -16803 lines) Patch
M BUILD.gn View 1 2 5 chunks +44 lines, -44 lines 0 comments Download
D src/array.js View 1 1 chunk +0 lines, -1659 lines 0 comments Download
D src/array-iterator.js View 1 chunk +0 lines, -172 lines 0 comments Download
D src/arraybuffer.js View 1 1 chunk +0 lines, -108 lines 0 comments Download
D src/code-stubs.js View 1 chunk +0 lines, -69 lines 0 comments Download
D src/collection.js View 1 chunk +0 lines, -504 lines 0 comments Download
D src/collection-iterator.js View 1 chunk +0 lines, -176 lines 0 comments Download
M src/d8.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
D src/date.js View 1 chunk +0 lines, -883 lines 0 comments Download
D src/generator.js View 1 chunk +0 lines, -114 lines 0 comments Download
D src/harmony-array.js View 1 1 chunk +0 lines, -298 lines 0 comments Download
D src/harmony-array-includes.js View 1 chunk +0 lines, -108 lines 0 comments Download
D src/harmony-atomics.js View 1 1 chunk +0 lines, -213 lines 0 comments Download
D src/harmony-concat-spreadable.js View 1 chunk +0 lines, -19 lines 0 comments Download
D src/harmony-object-observe.js View 1 chunk +0 lines, -14 lines 0 comments Download
D src/harmony-reflect.js View 1 chunk +0 lines, -20 lines 0 comments Download
D src/harmony-regexp.js View 1 chunk +0 lines, -37 lines 0 comments Download
D src/harmony-sharedarraybuffer.js View 1 chunk +0 lines, -57 lines 0 comments Download
D src/harmony-simd.js View 1 chunk +0 lines, -913 lines 0 comments Download
D src/harmony-spread.js View 1 chunk +0 lines, -51 lines 0 comments Download
D src/harmony-tostring.js View 1 chunk +0 lines, -19 lines 0 comments Download
D src/harmony-typedarray.js View 1 1 chunk +0 lines, -412 lines 0 comments Download
D src/i18n.js View 1 chunk +0 lines, -2118 lines 0 comments Download
D src/iterator-prototype.js View 1 chunk +0 lines, -22 lines 0 comments Download
A + src/js/array.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/array-iterator.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/arraybuffer.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/code-stubs.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/collection.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/collection-iterator.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/date.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/generator.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/harmony-array.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/harmony-array-includes.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/harmony-atomics.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/harmony-concat-spreadable.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/harmony-object-observe.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/harmony-reflect.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/harmony-regexp.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/harmony-sharedarraybuffer.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/harmony-simd.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/harmony-spread.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/harmony-tostring.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/harmony-typedarray.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/i18n.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/iterator-prototype.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/json.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/macros.py View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/math.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/messages.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/object-observe.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/prologue.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/promise.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/proxy.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/regexp.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/runtime.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/string.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/string-iterator.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/symbol.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/templates.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/typedarray.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/uri.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/v8natives.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/js/weak-collection.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D src/json.js View 1 1 chunk +0 lines, -254 lines 0 comments Download
D src/macros.py View 1 2 1 chunk +0 lines, -313 lines 0 comments Download
D src/math.js View 1 chunk +0 lines, -366 lines 0 comments Download
D src/messages.js View 1 chunk +0 lines, -1046 lines 0 comments Download
D src/object-observe.js View 1 chunk +0 lines, -720 lines 0 comments Download
D src/prologue.js View 1 chunk +0 lines, -312 lines 0 comments Download
D src/promise.js View 1 chunk +0 lines, -403 lines 0 comments Download
D src/proxy.js View 1 chunk +0 lines, -210 lines 0 comments Download
D src/regexp.js View 1 chunk +0 lines, -462 lines 0 comments Download
D src/runtime.js View 1 chunk +0 lines, -253 lines 0 comments Download
D src/string.js View 1 chunk +0 lines, -1206 lines 0 comments Download
D src/string-iterator.js View 1 chunk +0 lines, -96 lines 0 comments Download
D src/symbol.js View 1 chunk +0 lines, -134 lines 0 comments Download
D src/templates.js View 1 chunk +0 lines, -84 lines 0 comments Download
D src/typedarray.js View 1 chunk +0 lines, -508 lines 0 comments Download
D src/uri.js View 1 chunk +0 lines, -374 lines 0 comments Download
D src/v8natives.js View 1 chunk +0 lines, -1850 lines 0 comments Download
D src/weak-collection.js View 1 chunk +0 lines, -178 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 2 chunks +43 lines, -43 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
Michael Starzinger
5 years, 2 months ago (2015-10-08 11:57:03 UTC) #2
rossberg
LGTM But why not move the macros.py file along now?
5 years, 2 months ago (2015-10-13 08:19:19 UTC) #4
Michael Starzinger
On 2015/10/13 08:19:19, rossberg wrote: > But why not move the macros.py file along now? ...
5 years, 2 months ago (2015-10-13 08:39:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398733002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398733002/40001
5 years, 2 months ago (2015-10-13 08:51:41 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-13 09:38:16 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 09:38:56 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e5320d8a5990ab340b63328d3051598fe37dc338
Cr-Commit-Position: refs/heads/master@{#31230}

Powered by Google App Engine
This is Rietveld 408576698