Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1398703009: Next round of XFA changes to match master (Closed)

Created:
5 years, 2 months ago by Tom Sepez
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Next round of XFA changes to match master. This contains a missed merge of the Document:delay fixes. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/dfbf8e7ba55695c4e6cb30eadbe9c6a2955815ba

Patch Set 1 #

Total comments: 2

Patch Set 2 : Like the old code better. #

Patch Set 3 : remove arg #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -199 lines) Patch
M fpdfsdk/include/fsdk_define.h View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 2 chunks +2 lines, -3 lines 0 comments Download
M fpdfsdk/include/javascript/IJavaScript.h View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/formfiller/FFL_FormFiller.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M fpdfsdk/src/fpdf_progressive.cpp View 3 chunks +7 lines, -12 lines 0 comments Download
M fpdfsdk/src/fpdf_transformpage.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/fpdfformfill.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdftext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 1 chunk +3 lines, -8 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 6 chunks +0 lines, -13 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 7 chunks +8 lines, -23 lines 0 comments Download
M fpdfsdk/src/javascript/Document.h View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 8 chunks +25 lines, -92 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Define.h View 11 chunks +14 lines, -14 lines 0 comments Download
M fpdfsdk/src/javascript/JS_GlobalData.h View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M fpdfsdk/src/javascript/JS_GlobalData.cpp View 1 2 2 chunks +2 lines, -3 lines 1 comment Download
M fpdfsdk/src/javascript/PublicMethods.cpp View 4 chunks +15 lines, -14 lines 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ComboBox.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Tom Sepez
Lei, for review. https://codereview.chromium.org/1398703009/diff/1/fpdfsdk/include/fsdk_mgr.h File fpdfsdk/include/fsdk_mgr.h (left): https://codereview.chromium.org/1398703009/diff/1/fpdfsdk/include/fsdk_mgr.h#oldcode38 fpdfsdk/include/fsdk_mgr.h:38: virtual ~CPDFDoc_Environment(); argh. See final above.
5 years, 2 months ago (2015-10-14 20:02:31 UTC) #2
Lei Zhang
https://codereview.chromium.org/1398703009/diff/1/fpdfsdk/src/javascript/JS_GlobalData.cpp File fpdfsdk/src/javascript/JS_GlobalData.cpp (right): https://codereview.chromium.org/1398703009/diff/1/fpdfsdk/src/javascript/JS_GlobalData.cpp#newcode120 fpdfsdk/src/javascript/JS_GlobalData.cpp:120: CJS_GlobalData::CJS_GlobalData(CPDFDoc_Environment* pApp) : m_RefCount(0) { Why bother even passing ...
5 years, 2 months ago (2015-10-14 21:02:27 UTC) #3
Tom Sepez
On 2015/10/14 21:02:27, Lei Zhang wrote: > https://codereview.chromium.org/1398703009/diff/1/fpdfsdk/src/javascript/JS_GlobalData.cpp > File fpdfsdk/src/javascript/JS_GlobalData.cpp (right): > > https://codereview.chromium.org/1398703009/diff/1/fpdfsdk/src/javascript/JS_GlobalData.cpp#newcode120 ...
5 years, 2 months ago (2015-10-14 21:13:05 UTC) #4
Lei Zhang
lgtm if you want to fix it separately.
5 years, 2 months ago (2015-10-14 21:16:11 UTC) #5
Tom Sepez
Done.
5 years, 2 months ago (2015-10-14 21:16:25 UTC) #6
Tom Sepez
Committed patchset #3 (id:40001) manually as dfbf8e7ba55695c4e6cb30eadbe9c6a2955815ba (presubmit successful).
5 years, 2 months ago (2015-10-14 21:17:30 UTC) #7
Lei Zhang
5 years, 2 months ago (2015-10-14 21:18:41 UTC) #8
Message was sent while issue was closed. 
patch set 3 still lgtm, but exposes more cleanup.

https://codereview.chromium.org/1398703009/diff/40001/fpdfsdk/src/javascript/...
File fpdfsdk/src/javascript/JS_GlobalData.cpp (right):

https://codereview.chromium.org/1398703009/diff/40001/fpdfsdk/src/javascript/...
fpdfsdk/src/javascript/JS_GlobalData.cpp:105: CJS_GlobalData*
CJS_GlobalData::GetRetainedInstance(CPDFDoc_Environment* pApp) {
And in turn, |pApp| isn't needed here.

Powered by Google App Engine
This is Rietveld 408576698