Chromium Code Reviews| Index: fpdfsdk/src/javascript/JS_GlobalData.cpp |
| diff --git a/fpdfsdk/src/javascript/JS_GlobalData.cpp b/fpdfsdk/src/javascript/JS_GlobalData.cpp |
| index e13b50f5ef025285032eb0827b534d1b55db43dd..cf5b997dd2f925a799ea849f0c905eef0e410d7e 100644 |
| --- a/fpdfsdk/src/javascript/JS_GlobalData.cpp |
| +++ b/fpdfsdk/src/javascript/JS_GlobalData.cpp |
| @@ -104,7 +104,7 @@ CJS_GlobalData* CJS_GlobalData::g_Instance = nullptr; |
| // static |
| CJS_GlobalData* CJS_GlobalData::GetRetainedInstance(CPDFDoc_Environment* pApp) { |
|
Lei Zhang
2015/10/14 21:18:41
And in turn, |pApp| isn't needed here.
|
| if (!g_Instance) { |
| - g_Instance = new CJS_GlobalData(pApp); |
| + g_Instance = new CJS_GlobalData(); |
| } |
| ++g_Instance->m_RefCount; |
| return g_Instance; |
| @@ -117,8 +117,7 @@ void CJS_GlobalData::Release() { |
| } |
| } |
| -CJS_GlobalData::CJS_GlobalData(CPDFDoc_Environment* pApp) |
| - : m_pApp(pApp), m_RefCount(0) { |
| +CJS_GlobalData::CJS_GlobalData() : m_RefCount(0) { |
| m_sFilePath += SDK_JS_GLOBALDATA_FILENAME; |
| LoadGlobalPersistentVariables(); |
| } |