Pass replace_intrin=0 when running tests under ASan on OS X.

Pass replace_intrin=0 when running tests under ASan on OS X.
This suppresses an error in OpenCL, issue 162461.

BUG=162461, 170629
TBR=thakis

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=195775

[Alexander Potapenko, 2013-04-23 11:26:28]

TBRing to hotfix the bots.

[commit-bot: I haz the power, 2013-04-23 11:26:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/glider@chromium.org/13986012/1

[commit-bot: I haz the power, 2013-04-23 11:27:34]

Change committed as 195775

[Nico, 2013-04-23 15:48:18]

lgtm

Medium-term, is there any way to disable instrumentation of these functions less
globally?

[Alexander Potapenko, 2013-04-23 15:53:06]

+kcc
We deliberately didn't want to do this, because we wanted people to
fix their buffer overflows.
But this bug is deep in the third party code and is hard to fix, so we
may want to return to this problem.
I've tried to make a small reproducer and send it to Apple, but
failed. Maybe I should try again, or even give them the whole
instrumented browser.

On Tue, Apr 23, 2013 at 7:48 PM,  <thakis@chromium.org> wrote:
> lgtm
>
> Medium-term, is there any way to disable instrumentation of these functions
> less
> globally?
>
> https://codereview.chromium.org/13986012/



-- 
Alexander Potapenko
Software Engineer
Google Moscow

[kcc1, 2013-04-23 22:36:55]

Is this a Mac-only fix?


On Tue, Apr 23, 2013 at 8:53 AM, Alexander Potapenko
<glider@chromium.org>wrote:

> +kcc
> We deliberately didn't want to do this, because we wanted people to
> fix their buffer overflows.
> But this bug is deep in the third party code and is hard to fix, so we
> may want to return to this problem.
> I've tried to make a small reproducer and send it to Apple, but
> failed. Maybe I should try again, or even give them the whole
> instrumented browser.
>
> On Tue, Apr 23, 2013 at 7:48 PM,  <thakis@chromium.org> wrote:
> > lgtm
> >
> > Medium-term, is there any way to disable instrumentation of these
> functions
> > less
> > globally?
> >
> > https://codereview.chromium.org/13986012/
>
>
>
> --
> Alexander Potapenko
> Software Engineer
> Google Moscow
>

[Alexander Potapenko, 2013-04-24 06:21:43]

Yes, Mac-only.

Sent from phone
On Apr 24, 2013 2:36 AM, "Kostya Serebryany" <kcc@google.com> wrote:

> Is this a Mac-only fix?
>
>
> On Tue, Apr 23, 2013 at 8:53 AM, Alexander Potapenko
<glider@chromium.org>wrote:
>
>> +kcc
>> We deliberately didn't want to do this, because we wanted people to
>> fix their buffer overflows.
>> But this bug is deep in the third party code and is hard to fix, so we
>> may want to return to this problem.
>> I've tried to make a small reproducer and send it to Apple, but
>> failed. Maybe I should try again, or even give them the whole
>> instrumented browser.
>>
>> On Tue, Apr 23, 2013 at 7:48 PM,  <thakis@chromium.org> wrote:
>> > lgtm
>> >
>> > Medium-term, is there any way to disable instrumentation of these
>> functions
>> > less
>> > globally?
>> >
>> > https://codereview.chromium.org/13986012/
>>
>>
>>
>> --
>> Alexander Potapenko
>> Software Engineer
>> Google Moscow
>>
>
>