SyncFS: Introduce RemoteSyncOperationResolver for directory operation support

webkit/fileapi/syncable/file_change.h

Index: webkit/fileapi/syncable/file_change.h
diff --git a/webkit/fileapi/syncable/file_change.h b/webkit/fileapi/syncable/file_change.h
index f2a12e481eb0aca1b6b5306750e93b4a4484ec6c..41359a1c6b432c62320cdbb9883ad2a4afc246f0 100644
--- a/webkit/fileapi/syncable/file_change.h
+++ b/webkit/fileapi/syncable/file_change.h
@@ -32,6 +32,11 @@ class WEBKIT_STORAGE_EXPORT FileChange {
   bool IsDirectory() const { return file_type_ == SYNC_FILE_TYPE_DIRECTORY; }
   bool IsTypeUnknown() const { return !IsFile() && !IsDirectory(); }
 
+  bool IsAddOrUpdateFile() const { return IsAddOrUpdate() && IsFile(); }
+  bool IsDeleteFile() const { return IsDelete() && IsFile(); }
+  bool IsAddDirectory() const { return IsAddOrUpdate() && IsDirectory(); }
+  bool IsDeleteDirectory() const { return IsDelete() && IsDirectory(); }

[kinuko, 2013/04/24 02:32:32]

These methods are good for DCHECKs but I'm worried using them in a conditional
check as it makes easier to miss possible patterns

[nhiroki, 2013/04/24 13:29:05]

hmm... I think this seems straightforward and useful for building conditional
branches. Anyway I'll find a way to implement them simlply without these helper
functions.

[kinuko, 2013/04/24 14:07:59]

If it's really useful that's fine of course, I meant I usually prefer
switch/case because we can be warned when we have missing cases and it's easier
to add new cases.  In this case we can also assume we won't add any more
combinations (so that these 4 convenient methods will remain complete), but in
general.

+
   ChangeType change() const { return change_; }
   SyncFileType file_type() const { return file_type_; }