SyncFS: Introduce RemoteSyncOperationResolver for directory operation support

webkit/fileapi/syncable/file_change.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_FILEAPI_SYNCABLE_FILE_CHANGE_H_
 #define WEBKIT_FILEAPI_SYNCABLE_FILE_CHANGE_H_
 
 #include <deque>
 #include <string>
 
@@ skipping 14 matching lines @@
 
   FileChange(ChangeType change, SyncFileType file_type);
 
   bool IsAddOrUpdate() const { return change_ == FILE_CHANGE_ADD_OR_UPDATE; }
   bool IsDelete() const { return change_ == FILE_CHANGE_DELETE; }
 
   bool IsFile() const { return file_type_ == SYNC_FILE_TYPE_FILE; }
   bool IsDirectory() const { return file_type_ == SYNC_FILE_TYPE_DIRECTORY; }
   bool IsTypeUnknown() const { return !IsFile() && !IsDirectory(); }
 
+  bool IsAddOrUpdateFile() const { return IsAddOrUpdate() && IsFile(); }
+  bool IsDeleteFile() const { return IsDelete() && IsFile(); }
+  bool IsAddDirectory() const { return IsAddOrUpdate() && IsDirectory(); }
+  bool IsDeleteDirectory() const { return IsDelete() && IsDirectory(); }

[kinuko, 2013/04/24 02:32:32]

These methods are good for DCHECKs but I'm worried using them in a conditional
check as it makes easier to miss possible patterns

[nhiroki, 2013/04/24 13:29:05]

hmm... I think this seems straightforward and useful for building conditional
branches. Anyway I'll find a way to implement them simlply without these helper
functions.

[kinuko, 2013/04/24 14:07:59]

If it's really useful that's fine of course, I meant I usually prefer
switch/case because we can be warned when we have missing cases and it's easier
to add new cases.  In this case we can also assume we won't add any more
combinations (so that these 4 convenient methods will remain complete), but in
general.

+
   ChangeType change() const { return change_; }
   SyncFileType file_type() const { return file_type_; }
 
   std::string DebugString() const;
 
   bool operator==(const FileChange& that) const {
     return change() == that.change() &&
         file_type() == that.file_type();
   }
 
@@ skipping 22 matching lines @@
 
   std::string DebugString() const;
 
  private:
   List list_;
 };
 
 }  // namespace sync_file_system
 
 #endif  // WEBKIT_FILEAPI_SYNCABLE_FILE_CHANGE_H_