third_party/WebKit/Source/modules/vr/VRHardwareUnitCollection.h - Issue 1398523002: Use NoBaseWillBeGarbageCollectedFinalized for VRController as other LocalFrame supplements in modul…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/vr/VRHardwareUnitCollection.h

Issue 1398523002: Use NoBaseWillBeGarbageCollectedFinalized for VRController as other LocalFrame supplements in modul… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/vr/VRHardwareUnit.cpp ('k') | third_party/WebKit/Source/modules/vr/VRHardwareUnitCollection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/vr/VRHardwareUnitCollection.h

diff --git a/third_party/WebKit/Source/modules/vr/VRHardwareUnitCollection.h b/third_party/WebKit/Source/modules/vr/VRHardwareUnitCollection.h

index e273fd2b8894a6f8948e59605fdf9527b46110c6..cbdf63ffe286a63990b6fe84b37f0549ac48255a 100644

--- a/third_party/WebKit/Source/modules/vr/VRHardwareUnitCollection.h

+++ b/third_party/WebKit/Source/modules/vr/VRHardwareUnitCollection.h

@@ -16,7 +16,7 @@ struct WebVRDevice;

class VRHardwareUnitCollection final : public GarbageCollected<VRHardwareUnitCollection> {

public:

- explicit VRHardwareUnitCollection(VRController*);

+ explicit VRHardwareUnitCollection(NavigatorVRDevice*);

VRDeviceVector updateVRHardwareUnits(const WebVector<WebVRDevice>&);

VRHardwareUnit* getHardwareUnitForIndex(unsigned index);

@@ -24,7 +24,7 @@ public:

DECLARE_VIRTUAL_TRACE();

private:

- Member<VRController> m_controller;

+ Member<NavigatorVRDevice> m_navigatorVRDevice;

HeapVector<Member<VRHardwareUnit>> m_hardwareUnits;

};