Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: third_party/WebKit/Source/modules/vr/VRHardwareUnitCollection.cpp

Issue 1398523002: Use NoBaseWillBeGarbageCollectedFinalized for VRController as other LocalFrame supplements in modul… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/vr/VRHardwareUnitCollection.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/vr/VRHardwareUnitCollection.cpp
diff --git a/third_party/WebKit/Source/modules/vr/VRHardwareUnitCollection.cpp b/third_party/WebKit/Source/modules/vr/VRHardwareUnitCollection.cpp
index 9df7d7487f74b63d39b15ad0df33c0a1886668d6..383ab65c0704df62d21c17528f6669d567fe6a47 100644
--- a/third_party/WebKit/Source/modules/vr/VRHardwareUnitCollection.cpp
+++ b/third_party/WebKit/Source/modules/vr/VRHardwareUnitCollection.cpp
@@ -22,8 +22,8 @@
namespace blink {
-VRHardwareUnitCollection::VRHardwareUnitCollection(VRController* controller)
- : m_controller(controller)
+VRHardwareUnitCollection::VRHardwareUnitCollection(NavigatorVRDevice* navigatorVRDevice)
+ : m_navigatorVRDevice(navigatorVRDevice)
{
}
@@ -34,7 +34,7 @@ HeapVector<Member<VRDevice>> VRHardwareUnitCollection::updateVRHardwareUnits(con
for (const auto& device : devices) {
VRHardwareUnit* hardwareUnit = getHardwareUnitForIndex(device.index);
if (!hardwareUnit) {
- hardwareUnit = new VRHardwareUnit(m_controller);
+ hardwareUnit = new VRHardwareUnit(m_navigatorVRDevice);
m_hardwareUnits.append(hardwareUnit);
}
@@ -60,7 +60,7 @@ VRHardwareUnit* VRHardwareUnitCollection::getHardwareUnitForIndex(unsigned index
DEFINE_TRACE(VRHardwareUnitCollection)
{
- visitor->trace(m_controller);
+ visitor->trace(m_navigatorVRDevice);
visitor->trace(m_hardwareUnits);
}
« no previous file with comments | « third_party/WebKit/Source/modules/vr/VRHardwareUnitCollection.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698