Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1398473002: Revert the fix for 538784. (Closed)

Created:
5 years, 2 months ago by ncarter (slow)
Modified:
5 years, 2 months ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@no_isolate_apps3_fix_unittest
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert the fix for 538784 and disable its test. I'll re-land this after fixing up unittests that inadvertently depended on the unsafe behavior. BUG=538784 TBR=nasko@chromium.org Committed: https://crrev.com/f3b22237bceb64cc0a3be9ecbdc2d7da83ef6e54 Cr-Commit-Position: refs/heads/master@{#352943}

Patch Set 1 #

Patch Set 2 : Change upstream. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M content/browser/loader/cross_site_resource_handler.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/loader/cross_site_resource_handler_browsertest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
ncarter (slow)
5 years, 2 months ago (2015-10-07 18:03:22 UTC) #2
ncarter (slow)
TBRing since this is turning the site isolation bot red currently.
5 years, 2 months ago (2015-10-07 18:04:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398473002/1
5 years, 2 months ago (2015-10-07 18:09:16 UTC) #5
commit-bot: I haz the power
Failed to apply patch for content/browser/loader/cross_site_resource_handler.cc: While running git apply --index -3 -p1; error: patch ...
5 years, 2 months ago (2015-10-07 19:25:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398473002/20001
5 years, 2 months ago (2015-10-07 20:10:48 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-07 21:05:09 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 21:05:46 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f3b22237bceb64cc0a3be9ecbdc2d7da83ef6e54
Cr-Commit-Position: refs/heads/master@{#352943}

Powered by Google App Engine
This is Rietveld 408576698