Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1385603004: Move IsRendererTransferNeededForNavigation to RenderFrameHostManager. (Closed)

Created:
5 years, 2 months ago by ncarter (slow)
Modified:
5 years, 2 months ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@no_isolate_apps2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move IsRendererTransferNeededForNavigation to RenderFrameHostManager. This is a mechanical change, except for the treatment of guests, which switches from using a WebContents (forbidden under frame_host/) to using the guest scheme on the site URL. BUG=535073 Committed: https://crrev.com/b3e1cccd0316eab164af3b0da01890c1b10693fc Cr-Commit-Position: refs/heads/master@{#352458}

Patch Set 1 #

Patch Set 2 : fix clang compile. #

Patch Set 3 : Add test comment. #

Patch Set 4 : Pull in fixes from other patch #

Messages

Total messages: 7 (2 generated)
ncarter (slow)
Nasko: this depends on the other patch which you just lgtm'ed.
5 years, 2 months ago (2015-10-05 19:04:06 UTC) #2
nasko
LGTM
5 years, 2 months ago (2015-10-05 22:38:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385603004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385603004/60001
5 years, 2 months ago (2015-10-05 22:52:48 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-05 23:02:13 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 23:04:38 UTC) #7
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b3e1cccd0316eab164af3b0da01890c1b10693fc
Cr-Commit-Position: refs/heads/master@{#352458}

Powered by Google App Engine
This is Rietveld 408576698