chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java - Issue 1398423002: Add progressbar to animated doodle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 1398423002: Add progressbar to animated doodle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add showLoading() to ntpview Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/res/layout/eb_main_content.xml ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoView.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

index 11da2a342c8619b3eee5972728ee1128ece0e2a1..6d562f25bea09abd55349856d77f3f0681363e45 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

@@ -369,6 +369,7 @@ public class NewTabPage

if (mIsDestroyed) return;

if (!isAnimatedLogoShowing && mAnimatedLogoUrl != null) {

+ mNewTabPageView.showLogoLoadingView();

mLogoBridge.getAnimatedLogo(new LogoBridge.AnimatedLogoCallback() {

@Override

public void onAnimatedLogoAvailable(BaseGifImage animatedLogoImage) {