chrome/android/java/res/layout/eb_main_content.xml - Issue 1398423002: Add progressbar to animated doodle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/eb_main_content.xml

Issue 1398423002: Add progressbar to animated doodle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add showLoading() to ntpview Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/res/layout/eb_main_content.xml

diff --git a/chrome/android/java/res/layout/eb_main_content.xml b/chrome/android/java/res/layout/eb_main_content.xml

index 0fdc7efdc32ea6dde133f38188d005f3caf4af2e..bbd2cde3686e25728ec7444e22d66ddf1ba040c4 100644

--- a/chrome/android/java/res/layout/eb_main_content.xml

+++ b/chrome/android/java/res/layout/eb_main_content.xml

@@ -35,27 +35,20 @@

android:textSize="16sp"

android:visibility="gone" />

- <org.chromium.chrome.browser.enhancedbookmarks.EnhancedBookmarkLoadingView

+ <org.chromium.chrome.browser.widget.LoadingView

android:id="@+id/eb_initial_loading_view"

- android:layout_width="match_parent"

- android:layout_height="match_parent"

- android:background="#f2f2f2"

+ android:layout_width="wrap_content"

+ android:layout_height="wrap_content"

+ android:layout_centerInParent="true"

android:visibility="gone" >

newt (away) 2015/10/30 21:43:12 nit: since this doesn't contain any child views, j

- <ProgressBar

- android:id="@+id/eb_loading_circle"

- android:layout_width="wrap_content"

- android:layout_height="wrap_content"

- android:layout_gravity="center"

- android:layout_centerInParent="true"

- android:visibility="gone" />

- </org.chromium.chrome.browser.enhancedbookmarks.EnhancedBookmarkLoadingView>

+ </org.chromium.chrome.browser.widget.LoadingView>

<org.chromium.chrome.browser.enhancedbookmarks.EnhancedBookmarkActionBar

android:id="@id/eb_action_bar"

android:layout_width="match_parent"

android:layout_height="?attr/actionBarSize"

- android:layout_alignParentTop="true" >

+ android:layout_alignParentTop="true"

+ android:background="@color/enhanced_bookmark_appbar_background" >

<org.chromium.chrome.browser.widget.NumberRollView

android:id="@+id/selection_mode_number"