Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1398373004: Correct histogram enum id for IDC_CONTENT_CONTEXT_SAVEAVAS in context menu. (Closed)

Created:
5 years, 2 months ago by edwardjung
Modified:
5 years, 2 months ago
Reviewers:
lazyboy, rkaplow
CC:
chromium-reviews, mohsen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct histogram enum id for IDC_CONTENT_CONTEXT_SAVEAVAS in context menu. BUG= Committed: https://crrev.com/eb1a62b09f69de8232e6e5fa902d3b068b8660ae Cr-Commit-Position: refs/heads/master@{#353923}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add enum value for "Save media as" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
edwardjung
Hi, please take a look at this CL to fix a UMA histogram enumeration id ...
5 years, 2 months ago (2015-10-13 13:10:47 UTC) #2
lazyboy
https://codereview.chromium.org/1398373004/diff/1/chrome/browser/renderer_context_menu/render_view_context_menu.cc File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): https://codereview.chromium.org/1398373004/diff/1/chrome/browser/renderer_context_menu/render_view_context_menu.cc#newcode186 chrome/browser/renderer_context_menu/render_view_context_menu.cc:186: {7, 14, IDC_CONTENT_CONTEXT_SAVEAVAS}, 14 is "Save video", however IDC_CONTENT_CONTEXT_SAVEAVAS ...
5 years, 2 months ago (2015-10-13 17:28:30 UTC) #3
edwardjung
Added rkaplow to review addition to histograms.xml. Updated thanks. https://codereview.chromium.org/1398373004/diff/1/chrome/browser/renderer_context_menu/render_view_context_menu.cc File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): https://codereview.chromium.org/1398373004/diff/1/chrome/browser/renderer_context_menu/render_view_context_menu.cc#newcode186 chrome/browser/renderer_context_menu/render_view_context_menu.cc:186: ...
5 years, 2 months ago (2015-10-13 19:09:30 UTC) #5
lazyboy
render_view_content_menu.cc LGTM.
5 years, 2 months ago (2015-10-13 19:15:13 UTC) #6
rkaplow
lgtm
5 years, 2 months ago (2015-10-13 21:00:40 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398373004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398373004/20001
5 years, 2 months ago (2015-10-13 22:57:43 UTC) #9
edwardjung
+Mohsen as FYI that I added another enum id for 'Save media as' so you ...
5 years, 2 months ago (2015-10-13 23:00:21 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-14 00:20:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398373004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398373004/20001
5 years, 2 months ago (2015-10-14 00:23:52 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-14 00:36:31 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 00:37:18 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/eb1a62b09f69de8232e6e5fa902d3b068b8660ae
Cr-Commit-Position: refs/heads/master@{#353923}

Powered by Google App Engine
This is Rietveld 408576698