Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: chrome/browser/renderer_context_menu/render_view_context_menu.cc

Issue 1398373004: Correct histogram enum id for IDC_CONTENT_CONTEXT_SAVEAVAS in context menu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h" 5 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <set> 8 #include <set>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 /* 176 /*
177 enum id for 0, 1 are detected using 177 enum id for 0, 1 are detected using
178 RenderViewContextMenu::IsContentCustomCommandId and 178 RenderViewContextMenu::IsContentCustomCommandId and
179 ContextMenuMatcher::IsExtensionsCustomCommandId 179 ContextMenuMatcher::IsExtensionsCustomCommandId
180 */ 180 */
181 {2, -1, IDC_CONTENT_CONTEXT_PROTOCOL_HANDLER_FIRST}, 181 {2, -1, IDC_CONTENT_CONTEXT_PROTOCOL_HANDLER_FIRST},
182 {3, 0, IDC_CONTENT_CONTEXT_OPENLINKNEWTAB}, 182 {3, 0, IDC_CONTENT_CONTEXT_OPENLINKNEWTAB},
183 {4, 15, IDC_CONTENT_CONTEXT_OPENLINKNEWWINDOW}, 183 {4, 15, IDC_CONTENT_CONTEXT_OPENLINKNEWWINDOW},
184 {5, 1, IDC_CONTENT_CONTEXT_OPENLINKOFFTHERECORD}, 184 {5, 1, IDC_CONTENT_CONTEXT_OPENLINKOFFTHERECORD},
185 {6, 5, IDC_CONTENT_CONTEXT_SAVELINKAS}, 185 {6, 5, IDC_CONTENT_CONTEXT_SAVELINKAS},
186 {7, 17, IDC_CONTENT_CONTEXT_SAVEAVAS}, 186 {7, 14, IDC_CONTENT_CONTEXT_SAVEAVAS},
lazyboy 2015/10/13 17:28:30 14 is "Save video", however IDC_CONTENT_CONTEXT_SA
edwardjung 2015/10/13 19:09:30 Makes sense, that option was created for Chrome fo
187 {8, 6, IDC_CONTENT_CONTEXT_SAVEIMAGEAS}, 187 {8, 6, IDC_CONTENT_CONTEXT_SAVEIMAGEAS},
188 {9, 2, IDC_CONTENT_CONTEXT_COPYLINKLOCATION}, 188 {9, 2, IDC_CONTENT_CONTEXT_COPYLINKLOCATION},
189 {10, 10, IDC_CONTENT_CONTEXT_COPYIMAGELOCATION}, 189 {10, 10, IDC_CONTENT_CONTEXT_COPYIMAGELOCATION},
190 {11, -1, IDC_CONTENT_CONTEXT_COPYAVLOCATION}, 190 {11, -1, IDC_CONTENT_CONTEXT_COPYAVLOCATION},
191 {12, 9, IDC_CONTENT_CONTEXT_COPYIMAGE}, 191 {12, 9, IDC_CONTENT_CONTEXT_COPYIMAGE},
192 {13, 8, IDC_CONTENT_CONTEXT_OPENIMAGENEWTAB}, 192 {13, 8, IDC_CONTENT_CONTEXT_OPENIMAGENEWTAB},
193 {14, -1, IDC_CONTENT_CONTEXT_OPENAVNEWTAB}, 193 {14, -1, IDC_CONTENT_CONTEXT_OPENAVNEWTAB},
194 {15, -1, IDC_CONTENT_CONTEXT_PLAYPAUSE}, 194 {15, -1, IDC_CONTENT_CONTEXT_PLAYPAUSE},
195 {16, -1, IDC_CONTENT_CONTEXT_MUTE}, 195 {16, -1, IDC_CONTENT_CONTEXT_MUTE},
196 {17, -1, IDC_CONTENT_CONTEXT_LOOP}, 196 {17, -1, IDC_CONTENT_CONTEXT_LOOP},
(...skipping 1780 matching lines...) Expand 10 before | Expand all | Expand 10 after
1977 source_web_contents_->GetRenderViewHost()-> 1977 source_web_contents_->GetRenderViewHost()->
1978 ExecuteMediaPlayerActionAtLocation(location, action); 1978 ExecuteMediaPlayerActionAtLocation(location, action);
1979 } 1979 }
1980 1980
1981 void RenderViewContextMenu::PluginActionAt( 1981 void RenderViewContextMenu::PluginActionAt(
1982 const gfx::Point& location, 1982 const gfx::Point& location,
1983 const WebPluginAction& action) { 1983 const WebPluginAction& action) {
1984 source_web_contents_->GetRenderViewHost()-> 1984 source_web_contents_->GetRenderViewHost()->
1985 ExecutePluginActionAtLocation(location, action); 1985 ExecutePluginActionAtLocation(location, action);
1986 } 1986 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698