Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1398333002: Extract protocol_dart.dart APIs. (Closed)

Created:
5 years, 2 months ago by scheglov
Modified:
5 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add new files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -898 lines) Patch
A pkg/analysis_server/lib/plugin/protocol/protocol_dart.dart View 1 1 chunk +218 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/protocol_server.dart View 6 chunks +4 lines, -205 lines 0 comments Download
M pkg/analysis_server/lib/src/search/search_domain.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/search/type_hierarchy.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/inherited_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/test/plugin/protocol_dart_test.dart View 1 18 chunks +35 lines, -217 lines 0 comments Download
M pkg/analysis_server/test/plugin/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/protocol_server_test.dart View 5 chunks +4 lines, -465 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 2 months ago (2015-10-12 03:23:36 UTC) #1
Brian Wilkerson
LGTM
5 years, 2 months ago (2015-10-12 13:13:58 UTC) #2
scheglov
5 years, 2 months ago (2015-10-12 13:58:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
78da03cd97693219b677b7ff8ca5b62900abc444 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698