pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart - Issue 1398333002: Extract protocol_dart.dart APIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart

Issue 1398333002: Extract protocol_dart.dart APIs. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Add new files. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/search/type_hierarchy.dart ('k') | pkg/analysis_server/lib/src/services/completion/inherited_contributor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart b/pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart

index 7aa670474f96088ba7d05a2f9603cd857683e3ef..2fbe91e867184ade29e1fb3b1c645591e6d12ee7 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart

@@ -271,7 +271,7 @@ class DartCompletionCache extends CompletionCache {

false);

LibraryElement lib = importElem.importedLibrary;

if (lib != null) {

- suggestion.element = newElement_fromEngine(lib);

+ suggestion.element = convertElement(lib);

}

libraryPrefixSuggestions.add(suggestion);

_importedCompletions.add(suggestion.completion);