Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 1398213005: tquery: Remove hard dependency on UI (Closed)

Created:
5 years, 2 months ago by Sami
Modified:
5 years, 2 months ago
Reviewers:
petrcermak
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Base URL:
https://github.com/catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

tquery: Remove hard dependency on UI Make it possible to use tquery without depending on UI objects (BrushingStateController). Also unbreak tquery in the process. Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/4d7eedc5a080bf868fcb9c4053d023cde5a46aa6

Patch Set 1 #

Total comments: 16

Patch Set 2 : Review comments. #

Total comments: 8

Patch Set 3 : More review tweaks. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -131 lines) Patch
M tracing/tracing/core/scripting_controller.html View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/core/scripting_object.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/extras/tquery/tquery.html View 1 5 chunks +35 lines, -22 lines 0 comments Download
M tracing/tracing/extras/tquery/tquery_test.html View 1 7 chunks +44 lines, -99 lines 0 comments Download
M tracing/tracing/ui/scripting_control.html View 1 2 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Sami
5 years, 2 months ago (2015-10-15 16:58:41 UTC) #2
petrcermak
Looks good overall. Here's a bunch of comments. One more nit: I personally prefer "UI" ...
5 years, 2 months ago (2015-10-15 17:38:42 UTC) #3
Sami
Thanks for the comments; all addressed. https://codereview.chromium.org/1398213005/diff/1/tracing/tracing/core/scripting_controller.html File tracing/tracing/core/scripting_controller.html (right): https://codereview.chromium.org/1398213005/diff/1/tracing/tracing/core/scripting_controller.html#newcode45 tracing/tracing/core/scripting_controller.html:45: }.bind(this)); On 2015/10/15 ...
5 years, 2 months ago (2015-10-15 18:03:22 UTC) #4
petrcermak
LGTM with a few more comments. Thanks, Petr https://codereview.chromium.org/1398213005/diff/1/tracing/tracing/core/scripting_controller.html File tracing/tracing/core/scripting_controller.html (right): https://codereview.chromium.org/1398213005/diff/1/tracing/tracing/core/scripting_controller.html#newcode45 tracing/tracing/core/scripting_controller.html:45: }.bind(this)); ...
5 years, 2 months ago (2015-10-15 18:28:00 UTC) #5
Sami
https://codereview.chromium.org/1398213005/diff/1/tracing/tracing/core/scripting_controller.html File tracing/tracing/core/scripting_controller.html (right): https://codereview.chromium.org/1398213005/diff/1/tracing/tracing/core/scripting_controller.html#newcode45 tracing/tracing/core/scripting_controller.html:45: }.bind(this)); On 2015/10/15 18:28:00, petrcermak wrote: > On 2015/10/15 ...
5 years, 2 months ago (2015-10-15 18:34:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398213005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398213005/40001
5 years, 2 months ago (2015-10-15 18:34:53 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 18:41:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698