Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: tracing/tracing/ui/scripting_control.html

Issue 1398213005: tquery: Remove hard dependency on UI (Closed) Base URL: https://github.com/catapult-project/catapult@master
Patch Set: More review tweaks. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/extras/tquery/tquery_test.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/ui/scripting_control.html
diff --git a/tracing/tracing/ui/scripting_control.html b/tracing/tracing/ui/scripting_control.html
index 798302b93d165502b02e53f80843a986681da705..fe4c7113d80bf4df8fc6991fc7866c559dd577f2 100644
--- a/tracing/tracing/ui/scripting_control.html
+++ b/tracing/tracing/ui/scripting_control.html
@@ -5,9 +5,6 @@ Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file.
-->
-<link rel="import" href="/tracing/base/task.html">
-<link rel="import" href="/tracing/core/scripting_controller.html">
-<link rel="import" href="/tracing/ui/timeline_track_view.html">
<link rel="import" href="/tracing/extras/tquery/tquery.html">
<polymer-element
@@ -133,9 +130,13 @@ found in the LICENSE file.
result = e.stack || e.stackTrace;
}
- if (result instanceof tr.b.Task) {
+ if (result instanceof tr.e.tquery.TQuery) {
// TODO(skyostil): Show a cool spinner.
- tr.b.Task.RunWhenIdle(result);
+ result.ready().then(function(selection) {
+ this.addLine_(selection.length + ' matches');
+ this.controller_.brushingStateController.
+ showScriptControlSelection(selection);
+ }.bind(this));
} else {
this.addLine_(result);
}
« no previous file with comments | « tracing/tracing/extras/tquery/tquery_test.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698