Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1712)

Unified Diff: Source/heap/Visitor.h

Issue 139803012: Move speech module over to Oilpan. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Pull in TraceTrait<RefPtr<T>> template specialization + add trace() over RawPtr<T>s. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/heap/Visitor.h
diff --git a/Source/heap/Visitor.h b/Source/heap/Visitor.h
index 864dd884aa687f9bd42887928369db9701f09563..0dc62ab25c9f1f65954d087c797272b87e0e0eff 100644
--- a/Source/heap/Visitor.h
+++ b/Source/heap/Visitor.h
@@ -319,6 +319,18 @@ public:
#endif
}
+ // Similarly, this trace method is to trace a RawPtrWillBeMember
+ // when ENABLE(OILPAN) is not enabled.
+ // Remove this once we remove RawPtrWillBeMember.
+ template<typename T>
+ void trace(const RawPtr<T>&)
+ {
+#if ENABLE(OILPAN)
+ // RawPtrs should never be traced.
+ ASSERT_NOT_REACHED();
zerny-chromium 2014/02/13 07:02:28 I think this should be the case, since the only "r
+#endif
+ }
+
// This method marks an object and adds it to the set of objects
// that should have their trace method called. Since not all
// objects have vtables we have to have the callback as an

Powered by Google App Engine
This is Rietveld 408576698