Issue 139803002: win ninja: build fix for msvs_pre/postbuild error test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 139803002: win ninja: build fix for msvs_pre/postbuild error test (Closed)

Created:
6 years, 11 months ago by scottmg

Modified:
6 years, 11 months ago

Reviewers:
bradn

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

win ninja: build fix for msvs_pre/postbuild error test Follow up to r1837. The previous test used print, which can get lost when running in parallel. Instead, just error out with an exception and update the test to expect that. TBR=bradn@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1838

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -9 lines)			Patch
	M	pylib/gyp/msvs_emulation.py	View		1 chunk	+5 lines, -3 lines	0 comments	Download
	M	test/msvs/buildevents/gyptest-ninja-warnings.py	View		1 chunk	+11 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

scottmg

6 years, 11 months ago (2014-01-15 18:57:15 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r1838 (presubmit successful).

Expand Messages | Collapse Messages