Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: pylib/gyp/msvs_emulation.py

Issue 139803002: win ninja: build fix for msvs_pre/postbuild error test (Closed) Base URL: http://gyp.googlecode.com/svn/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/msvs/buildevents/gyptest-ninja-warnings.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/msvs_emulation.py
diff --git a/pylib/gyp/msvs_emulation.py b/pylib/gyp/msvs_emulation.py
index 618478d1c9fe7398a465fc892ff3d168b81aefb7..709ba305d2828e5546007c10c0dc1bc441b98662 100644
--- a/pylib/gyp/msvs_emulation.py
+++ b/pylib/gyp/msvs_emulation.py
@@ -167,12 +167,14 @@ class MsvsSettings(object):
'msvs_prebuild',
'msvs_postbuild',
]
+ unsupported = []
for field in unsupported_fields:
for config in configs.values():
if field in config:
- print "Warning: %s not supported, dropping. (target %s)" \
- % (field, spec['target_name'])
- break
+ unsupported += ["%s not supported (target %s)." %
+ (field, spec['target_name'])]
+ if unsupported:
+ raise Exception('\n'.join(unsupported))
def GetVSMacroEnv(self, base_to_build=None, config=None):
"""Get a dict of variables mapping internal VS macro names to their gyp
« no previous file with comments | « no previous file | test/msvs/buildevents/gyptest-ninja-warnings.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698