Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: ui/gfx/range/range_mac_unittest.mm

Issue 1398013003: mac: Make gfx_unittests and skia_unittests build with the 10.11 SDK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« skia/ext/skia_utils_mac_unittest.mm ('K') | « skia/ext/skia_utils_mac_unittest.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/range/range_mac_unittest.mm
diff --git a/ui/gfx/range/range_mac_unittest.mm b/ui/gfx/range/range_mac_unittest.mm
index c04cbfe9503a93db2387fa2d050a2e8bfe4bcae8..85323f27ce88c60aa4b949994c407643394bf6cd 100644
--- a/ui/gfx/range/range_mac_unittest.mm
+++ b/ui/gfx/range/range_mac_unittest.mm
@@ -38,6 +38,6 @@ TEST(RangeTest, FromNSRangeInvalid) {
TEST(RangeTest, ToNSRangeInvalid) {
gfx::Range r(gfx::Range::InvalidRange());
NSRange nsr = r.ToNSRange();
- EXPECT_EQ(NSNotFound, nsr.location);
+ EXPECT_EQ(static_cast<NSUInteger>(NSNotFound), nsr.location);
Nico 2015/10/09 17:42:04 Here, the signedness of NSNotFound apparently chan
Robert Sesek 2015/10/09 18:19:13 That's really weird. NSNotFound = NSIntegerMax but
EXPECT_EQ(0U, nsr.length);
}
« skia/ext/skia_utils_mac_unittest.mm ('K') | « skia/ext/skia_utils_mac_unittest.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698