ui/gfx/range/range_mac_unittest.mm - Issue 1398013003: mac: Make gfx_unittests and skia_unittests build with the 10.11 SDK.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gfx/range/range_mac_unittest.mm

Issue 1398013003: mac: Make gfx_unittests and skia_unittests build with the 10.11 SDK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« skia/ext/skia_utils_mac_unittest.mm ('K') | « skia/ext/skia_utils_mac_unittest.mm ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "testing/gtest/include/gtest/gtest.h"	5 #include "testing/gtest/include/gtest/gtest.h"

6 #include "ui/gfx/range/range.h"	6 #include "ui/gfx/range/range.h"

7	7

8 TEST(RangeTest, FromNSRange) {	8 TEST(RangeTest, FromNSRange) {

9 NSRange nsr = NSMakeRange(10, 3);	9 NSRange nsr = NSMakeRange(10, 3);

10 gfx::Range r(nsr);	10 gfx::Range r(nsr);

(...skipping 20 matching lines...) Expand all Loading...
31	31

32 TEST(RangeTest, FromNSRangeInvalid) {	32 TEST(RangeTest, FromNSRangeInvalid) {

33 NSRange nsr = NSMakeRange(NSNotFound, 0);	33 NSRange nsr = NSMakeRange(NSNotFound, 0);

34 gfx::Range r(nsr);	34 gfx::Range r(nsr);

35 EXPECT_FALSE(r.IsValid());	35 EXPECT_FALSE(r.IsValid());

36 }	36 }

37	37

38 TEST(RangeTest, ToNSRangeInvalid) {	38 TEST(RangeTest, ToNSRangeInvalid) {

39 gfx::Range r(gfx::Range::InvalidRange());	39 gfx::Range r(gfx::Range::InvalidRange());

40 NSRange nsr = r.ToNSRange();	40 NSRange nsr = r.ToNSRange();

41 EXPECT_EQ(NSNotFound, nsr.location);	41 EXPECT_EQ(static_cast<NSUInteger>(NSNotFound), nsr.location);
	Nico 2015/10/09 17:42:04 Here, the signedness of NSNotFound apparently chan Here, the signedness of NSNotFound apparently changed? (it's a regular enum now) Robert Sesek 2015/10/09 18:19:13 That's really weird. NSNotFound = NSIntegerMax but Show quoted text On 2015/10/09 17:42:04, Nico (offline until Fri Oct 9) wrote: > Here, the signedness of NSNotFound apparently changed? (it's a regular enum now) That's really weird. NSNotFound = NSIntegerMax but NSRange has to NSUIntegers.
42 EXPECT_EQ(0U, nsr.length);	42 EXPECT_EQ(0U, nsr.length);

43 }	43 }

OLD	NEW