Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1398013003: mac: Make gfx_unittests and skia_unittests build with the 10.11 SDK. (Closed)

Created:
5 years, 2 months ago by Nico
Modified:
5 years, 2 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Make gfx_unittests and skia_unittests build with the 10.11 SDK. BUG=517914 Committed: https://crrev.com/333e69367d37a329d83337350cd3d4a573732de2 Cr-Commit-Position: refs/heads/master@{#353336}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M skia/ext/skia_utils_mac_unittest.mm View 3 chunks +6 lines, -2 lines 1 comment Download
M ui/gfx/range/range_mac_unittest.mm View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 7 (2 generated)
Nico
https://codereview.chromium.org/1398013003/diff/1/skia/ext/skia_utils_mac_unittest.mm File skia/ext/skia_utils_mac_unittest.mm (left): https://codereview.chromium.org/1398013003/diff/1/skia/ext/skia_utils_mac_unittest.mm#oldcode192 skia/ext/skia_utils_mac_unittest.mm:192: TestImageRep([[image representations] lastObject], isred); here the compiler now realizes ...
5 years, 2 months ago (2015-10-09 17:42:04 UTC) #2
Robert Sesek
LGTM I guess https://codereview.chromium.org/1398013003/diff/1/ui/gfx/range/range_mac_unittest.mm File ui/gfx/range/range_mac_unittest.mm (right): https://codereview.chromium.org/1398013003/diff/1/ui/gfx/range/range_mac_unittest.mm#newcode41 ui/gfx/range/range_mac_unittest.mm:41: EXPECT_EQ(static_cast<NSUInteger>(NSNotFound), nsr.location); On 2015/10/09 17:42:04, Nico ...
5 years, 2 months ago (2015-10-09 18:19:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398013003/1
5 years, 2 months ago (2015-10-09 18:25:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-09 18:39:16 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 18:40:12 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/333e69367d37a329d83337350cd3d4a573732de2
Cr-Commit-Position: refs/heads/master@{#353336}

Powered by Google App Engine
This is Rietveld 408576698