Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: src/IceTargetLoweringARM32.cpp

Issue 1397933002: Start incorporating the ARM integrated assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix nit and add URL. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceTargetLowering.cpp ('k') | src/IceTargetLoweringMIPS32.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTargetLoweringARM32.cpp
diff --git a/src/IceTargetLoweringARM32.cpp b/src/IceTargetLoweringARM32.cpp
index 26741908834a9ef905da62880e2cdd5ee66a0727..2615b36c6c4236daaee55fa4250ef90b1080bc30 100644
--- a/src/IceTargetLoweringARM32.cpp
+++ b/src/IceTargetLoweringARM32.cpp
@@ -37,18 +37,6 @@ namespace Ice {
namespace {
-// UnimplementedError is defined as a macro so that we can get actual line
-// numbers.
-#define UnimplementedError(Flags) \
- do { \
- if (!static_cast<const ClFlags &>(Flags).getSkipUnimplemented()) { \
- /* Use llvm_unreachable instead of report_fatal_error, which gives \
- better stack traces. */ \
- llvm_unreachable("Not yet implemented"); \
- abort(); \
- } \
- } while (0)
-
// The following table summarizes the logic for lowering the icmp instruction
// for i32 and narrower types. Each icmp condition has a clear mapping to an
// ARM32 conditional move instruction.
@@ -3871,16 +3859,13 @@ void TargetDataARM32::lowerConstants() {
case FT_Elf:
UnimplementedError(Ctx->getFlags());
break;
- case FT_Asm: {
+ case FT_Asm:
+ case FT_Iasm: {
OstreamLocker L(Ctx);
emitConstantPool<float>(Ctx);
emitConstantPool<double>(Ctx);
break;
}
- case FT_Iasm: {
- UnimplementedError(Ctx->getFlags());
- break;
- }
}
}
@@ -3895,7 +3880,7 @@ void TargetDataARM32::lowerJumpTables() {
// Already emitted from Cfg
break;
case FT_Iasm: {
- UnimplementedError(Ctx->getFlags());
+ // TODO(kschimpf): Fill this in when we get more information.
break;
}
}
« no previous file with comments | « src/IceTargetLowering.cpp ('k') | src/IceTargetLoweringMIPS32.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698