Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: src/DartARM32/assembler_arm.cc

Issue 1397933002: Start incorporating the ARM integrated assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix nit and add URL. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/DartARM32/assembler_arm.h ('k') | src/IceAssembler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/DartARM32/assembler_arm.cc
diff --git a/src/DartARM32/assembler_arm.cc b/src/DartARM32/assembler_arm.cc
index 5c0a90ed3376e58cc44dc4b3b9f922bdb87974b6..fee25dcd603e7b4681474e34a065fe7df63aab16 100644
--- a/src/DartARM32/assembler_arm.cc
+++ b/src/DartARM32/assembler_arm.cc
@@ -1433,9 +1433,12 @@ void Assembler::vcgtqs(QRegister qd, QRegister qn, QRegister qm) {
}
+#if 0
+// Moved to: ARM32::AssemblerARM32.
void Assembler::bkpt(uint16_t imm16) {
Emit(BkptEncoding(imm16));
}
+#endif
void Assembler::b(Label* label, Condition cond) {
@@ -1447,7 +1450,8 @@ void Assembler::bl(Label* label, Condition cond) {
EmitBranch(cond, label, true);
}
-
+#if 0
+// Moved to: ARM32::AssemblerARM32.
void Assembler::bx(Register rm, Condition cond) {
ASSERT(rm != kNoRegister);
ASSERT(cond != kNoCondition);
@@ -1456,6 +1460,7 @@ void Assembler::bx(Register rm, Condition cond) {
(static_cast<int32_t>(rm) << kRmShift);
Emit(encoding);
}
+#endif
void Assembler::blx(Register rm, Condition cond) {
@@ -2314,7 +2319,10 @@ void Assembler::BindARMv6(Label* label) {
label->BindTo(bound_pc);
}
-
+#if 0
+// Moved to: ARM32::AssemblerARM32 as method bind(Label* Label)
+// Note: Most of this code isn't needed because instruction selection has
+// already been handler
void Assembler::BindARMv7(Label* label) {
ASSERT(!label->IsBound());
intptr_t bound_pc = buffer_.Size();
@@ -2381,6 +2389,7 @@ void Assembler::BindARMv7(Label* label) {
}
label->BindTo(bound_pc);
}
+#endif
void Assembler::Bind(Label* label) {
« no previous file with comments | « src/DartARM32/assembler_arm.h ('k') | src/IceAssembler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698