Win: Display a native bubble (instead of the JS one) after the web signin flow.

chrome/browser/ui/browser_window.h

Index: chrome/browser/ui/browser_window.h
diff --git a/chrome/browser/ui/browser_window.h b/chrome/browser/ui/browser_window.h
index b97595202fd737ebaecc165c0eb2465754ab3643..b447da46c35e05fcf49d88e827921f31934eb2f8 100644
--- a/chrome/browser/ui/browser_window.h
+++ b/chrome/browser/ui/browser_window.h
@@ -5,6 +5,8 @@
 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_
 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_
 
+#include <string>
+
 #include "base/callback_forward.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/ui/base_window.h"
@@ -229,8 +231,9 @@ class BrowserWindow : public BaseWindow {
   virtual void ShowOneClickSigninBubble(
       OneClickSigninBubbleType type,
       const string16& email,
+      const std::string& error_message,

[Nico, 2013/04/18 17:53:28]

We used to use string16 for text that could possibly contain international text.
I think that's no longer true, but since the previous parameter is string16,
should error_message be string16 too?

[noms (inactive), 2013/04/18 18:08:28]

The error_message comes as a utf8 string from
OneClickSigninHelper::SigninFailed, where it seems to be
gotted/internationalized with l10n_util::GetStringUTF8.

I could convert it to string16() when ShowOneClickSigninBubble is called,
instead of when displaying it in the views label as I currently do -- would that
be better? I don't particularly know why it isn't got initially as a UTF16, but
one option I guess would also be changing that?


On 2013/04/18 17:53:28, Nico wrote:

[Roger Tawa OOO till Jul 10th, 2013/04/18 19:04:11]

It might have been utf8 previously because that is what the ntp bubble expected.
 But with the new bubble, changing to string16 in one-clicks-signin before
passing to ShowOneClickSigninBubble sounds good.

       const StartSyncCallback& start_sync_callback) = 0;
-#endif
+  #endif
 
   // Whether or not the shelf view is visible.
   virtual bool IsDownloadShelfVisible() const = 0;