Win: Display a native bubble (instead of the JS one) after the web signin flow.

chrome/browser/ui/browser_window.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_
 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_
 
+#include <string>
+
 #include "base/callback_forward.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/ui/base_window.h"
 #include "chrome/browser/ui/bookmarks/bookmark_bar.h"
 #include "chrome/browser/ui/fullscreen/fullscreen_exit_bubble_type.h"
 #include "chrome/browser/ui/host_desktop.h"
 #include "chrome/browser/ui/sync/one_click_signin_sync_starter.h"
 #include "chrome/common/content_settings_types.h"
 #include "ui/base/window_open_disposition.h"
 #include "ui/gfx/native_widget_types.h"
@@ skipping 204 matching lines @@
   // user chooses to accept the sign in, the callback is called to start the
   // sync process.
   typedef base::Callback<void(OneClickSigninSyncStarter::StartSyncMode)>
       StartSyncCallback;
 
   // Shows the one-click sign in bubble.  |email| holds the full email address
   // of the account that has signed in.
   virtual void ShowOneClickSigninBubble(
       OneClickSigninBubbleType type,
       const string16& email,
+      const std::string& error_message,

[Nico, 2013/04/18 17:53:28]

We used to use string16 for text that could possibly contain international text.
I think that's no longer true, but since the previous parameter is string16,
should error_message be string16 too?

[noms (inactive), 2013/04/18 18:08:28]

The error_message comes as a utf8 string from
OneClickSigninHelper::SigninFailed, where it seems to be
gotted/internationalized with l10n_util::GetStringUTF8.

I could convert it to string16() when ShowOneClickSigninBubble is called,
instead of when displaying it in the views label as I currently do -- would that
be better? I don't particularly know why it isn't got initially as a UTF16, but
one option I guess would also be changing that?


On 2013/04/18 17:53:28, Nico wrote:

[Roger Tawa OOO till Jul 10th, 2013/04/18 19:04:11]

It might have been utf8 previously because that is what the ntp bubble expected.
 But with the new bubble, changing to string16 in one-clicks-signin before
passing to ShowOneClickSigninBubble sounds good.

       const StartSyncCallback& start_sync_callback) = 0;
-#endif
+  #endif
 
   // Whether or not the shelf view is visible.
   virtual bool IsDownloadShelfVisible() const = 0;
 
   // Returns the DownloadShelf.
   virtual DownloadShelf* GetDownloadShelf() = 0;
 
   // Shows the confirmation dialog box warning that the browser is closing with
   // in-progress downloads.
   // This method should call Browser::InProgressDownloadResponse once the user
@@ skipping 143 matching lines @@
 
   // Returns the ToolbarView.
   virtual ToolbarView* GetToolbarView() const = 0;
 #endif
 
  protected:
   virtual ~BrowserWindowTesting() {}
 };
 
 #endif  // CHROME_BROWSER_UI_BROWSER_WINDOW_H_