Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5531)

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 13979003: Win: Display a native bubble (instead of the JS one) after the web signin flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Lint + review fixes Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm
index a199f222efaeed0e38b383ce3857eaeba947585c..512ef210c5098fe6f029745497ff6659ed0fbb4b 100644
--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm
+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm
@@ -480,7 +480,8 @@ void BrowserWindowCocoa::ShowChromeToMobileBubble() {
void BrowserWindowCocoa::ShowOneClickSigninBubble(
OneClickSigninBubbleType type,
const string16& email,
- const StartSyncCallback& start_sync_callback) {
+ const StartSyncCallback& start_sync_callback,
+ const std::string& error_message) {
if (type == ONE_CLICK_SIGNIN_BUBBLE_TYPE_BUBBLE) {
scoped_nsobject<OneClickSigninBubbleController> bubble_controller(
[[OneClickSigninBubbleController alloc]

Powered by Google App Engine
This is Rietveld 408576698